Skip to content

Update to React 19#239

Closed
sanderdesnaijer wants to merge 8 commits into
nomcopter:masterfrom
KNMI:master
Closed

Update to React 19#239
sanderdesnaijer wants to merge 8 commits into
nomcopter:masterfrom
KNMI:master

Conversation

@sanderdesnaijer

Copy link
Copy Markdown

Fixes #234

Changes proposed in this pull request:

Updates React to 19 and the react-dnd-multi-backend to version 9. Updated packages:

  • react
  • react-dom
  • @types/react
  • @types/react-dom
  • react-dnd-multi-backend
  • core-js

Reviewers should focus on:

  • should be able to run the tests yarn test
  • should be able to build yarn build

Note

Blueprint.js is not supporting React 19 at the moment, and probably wont in future for the current used version. Errors are shown in the ExampleApp but won't affect the build. The errors are muted by client.overlay inside the webpack/hot.ts file

@sanderdesnaijer

Copy link
Copy Markdown
Author

Hi @nomcopter, friendly ping on this PR for React 19 support when you have time. Happy to make changes if needed.

@nomcopter

Copy link
Copy Markdown
Owner

Thanks for the PR! @Lonli-Lokli is working on merging his fork in in #240 which will include an update to React 19 and so we'll hold off for that to prevent conflicts

@sanderdesnaijer

Copy link
Copy Markdown
Author

Allright thanks @nomcopter that sounds good!

@Lonli-Lokli

Copy link
Copy Markdown
Collaborator

New version landed, please check and open new issue if needed

@sanderdesnaijer

Copy link
Copy Markdown
Author

@Lonli-Lokli

Copy link
Copy Markdown
Collaborator

@sanderdesnaijer Thanks, should work now

@sanderdesnaijer

Copy link
Copy Markdown
Author

Awesome, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React 19 compatibility: update to react-dnd-multi-backend version 9

3 participants