Skip to content

Commit 34c28d5

Browse files
authored
Revert "http: do not emit socket errors after complete response"
This reverts commit 17163ea. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #64511 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent b4dfc78 commit 34c28d5

2 files changed

Lines changed: 1 addition & 70 deletions

File tree

lib/_http_client.js

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -752,24 +752,10 @@ function socketErrorListener(err) {
752752
debug('SOCKET ERROR:', err.message, err.stack);
753753

754754
if (req) {
755-
const res = req.res;
756-
const isUserDestroyError = err === req[kError] || err === res?.errored;
757-
758755
// For Safety. Some additional errors might fire later on
759756
// and we need to make sure we don't double-fire the error event.
760757
socket._hadError = true;
761-
// Before a response exists, the request itself failed. Once a response
762-
// exists, socket teardown belongs to the IncomingMessage and is finalized
763-
// by socketCloseListener. Preserve errors explicitly used to destroy the
764-
// request or response, which have historically been emitted on the request.
765-
if (!res || isUserDestroyError) {
766-
emitErrorEvent(req, err);
767-
}
768-
769-
if (res) {
770-
socket.destroy();
771-
return;
772-
}
758+
emitErrorEvent(req, err);
773759
}
774760

775761
const parser = socket.parser;

test/parallel/test-http-client-complete-response-reset.js

Lines changed: 0 additions & 55 deletions
This file was deleted.

0 commit comments

Comments
 (0)