http: guard invalid timeout values in checkConnections

Signed-off-by: Efe Karasakal <hi@efe.dev>
PR-URL: #64506
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Tim Perry <pimterry@gmail.com>

Author: efekrskl

lib/_http_server.js

@@ -742,11 +742,18 @@ assignFunctionName(EE.captureRejectionSymbol, function(err, event, ...args) {
 });
 
 function checkConnections() {
-  if (this.headersTimeout === 0 && this.requestTimeout === 0) {
+  const headersTimeout =
+    NumberIsFinite(this.headersTimeout) && this.headersTimeout >= 0 ?
+      this.headersTimeout : 0;
+  const requestTimeout =
+    NumberIsFinite(this.requestTimeout) && this.requestTimeout >= 0 ?
+      this.requestTimeout : 0;
+
+  if (headersTimeout === 0 && requestTimeout === 0) {
     return;
   }
 
-  const expired = this[kConnections].expired(this.headersTimeout, this.requestTimeout);
+  const expired = this[kConnections].expired(headersTimeout, requestTimeout);
 
   for (let i = 0; i < expired.length; i++) {
     const socket = expired[i].socket;

test/parallel/test-http-server-invalid-headers-timeout-no-abort.js

@@ -0,0 +1,19 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const { createServer } = require('http');
+
+const server = createServer({
+  connectionsCheckingInterval: 1,
+}, common.mustNotCall());
+
+// Invalid headersTimeout should not crash the server
+server.headersTimeout = 'im-not-a-number';
+assert.strictEqual(server.headersTimeout, 'im-not-a-number');
+
+server.listen(0, '127.0.0.1', common.mustCall(() => {
+  setTimeout(common.mustCall(() => {
+    server.close(common.mustCall());
+  }), common.platformTimeout(50));
+}));