Skip to content

[Bug]: can't add authors of the same name #492

Description

@Schiano-NOAA

Describe the bug

If you add the same author name and affiliation to the authors argument in create_template, the function will throw an error and fail.

This is the error message:

Error in `tidyr::separate_wider_regex()`:
! Expected each value of `input` to match
  the pattern, the whole pattern, and nothing but the pattern.
! 2 values have problems.
ℹ Use `too_few = "debug"` to diagnose the problem.
ℹ Use `too_few = "align_start"` to silence this message.

It needs to be tested under the conditions:

  • when affiliation is different
  • if it's just when author is repeated
  • when first and last are the same, but one contains a middle name

For future work: R&D should be done to see how you can set multiple affiliations for a single author

Describe how to reproduce the bug

Option 1:

library(asar)
create_template(authors = c("Jane Doe" = "SWFSC", "Jane Doe" = "SWFSC"))

Option 2 (more likely to cause error):

library(asar)
create_template(authors = c("Jane Doe" = SWFSC))
create_template(
  rerender_skeleton = TRUE,
  authors = c("Jane Doe" = "SWFSC")
)

Screenshots

No response

Which OS are you seeing the problem on?

No response

Which version of asar are you seeing the problem on?

No response

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtriage_neededThis issue needs review

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions