Dial-in room is handled differently than dial-out in frontend

[SystemKeeper]

Tip

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

For dial-out rooms: When you start a call, the phone participant is called directly. That is not the case for dial-in rooms. So if you want to call back someone, that will not work. Also we always show the media picker, which is not the case for dial-out.
Ref:

spreed/src/composables/useJoinCall.ts

Lines 34 to 41 in 994080b

	function isConversationPhoneRoom({ objectId, objectType }: Conversation) {
	return objectId === CONVERSATION.OBJECT_ID.PHONE_OUTGOING
	&& [
	CONVERSATION.OBJECT_TYPE.PHONE_LEGACY,
	CONVERSATION.OBJECT_TYPE.PHONE_PERSISTENT,
	CONVERSATION.OBJECT_TYPE.PHONE_TEMPORARY,
	].includes(objectType)
	}

and

spreed/src/components/TopBar/CallButton.vue

Lines 349 to 354 in 994080b

	isPhoneRoom() {
	return this.conversation.objectId === CONVERSATION.OBJECT_ID.PHONE_OUTGOING
	&& (this.conversation.objectType === CONVERSATION.OBJECT_TYPE.PHONE_LEGACY
	|| this.conversation.objectType === CONVERSATION.OBJECT_TYPE.PHONE_PERSISTENT
	|| this.conversation.objectType === CONVERSATION.OBJECT_TYPE.PHONE_TEMPORARY)
	},

and

spreed/src/composables/useJoinCall.ts

Lines 133 to 141 in 994080b

	if (isPhoneRoom) {
	const attendeeId = vuexStore.getters.participantsList(token)
	.find((participant: Participant) => participant.actorType === ATTENDEE.ACTOR_TYPE.PHONES)
	?.attendeeId
	if (attendeeId) {
	// Do not wait for async operation
	dialOutPhoneNumber(token, attendeeId)
	}
	}

Also, hanging up should use "end-for-all" to actually end the call, otherwise only the (talk-) participant will leave the conversation, but the phone stays connected.

Talk app

Talk app version: 34/main