Skip to content

feat(SIP): better indication of SIP streams / speaker identification #17472

@Antreesy

Description

@Antreesy

Tip

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Description

As per current implementation, when SIP Bridge devices are connected to the call in Talk, there would be two separate tiles when SIP Bridge is connected (regardless of how many phone users or Cisco devices connected):

  • one shared audio tile with all participants mixed
  • one shared video tile with currently speaking participant with video
SIP Bridge                                                    
│                                                             
│                                                             
├───► Audio stream ┌────► Hardware device 1 (speaking) ───┐   
│                  │                                      │   
│                  ├────► Hardware device 2            ───┼──► Talk audio
│                  │                                      │   
│                  └────► Phone user (from mobile) 1-∞ ───┘   
│                                                             
└───► Video stream ┌────► Hardware device 1 (speaking) ──┐    
                   │                                     ▼───► Talk video
                   └────► Hardware device 2            ──│       

Suggestion

  • Mark SIP Bridge connections in Talk call UI as 'Shared SIP Bridge audio/video', e.g. User (SIP audio)
    • Look into implementation and how to identify connections coming from SIP
    • adjust components CallView >> VideoBottomBar
  • Identify currently speaking SIP participants and display it in Talk call UI, e.g. User A (SIP video)
    • consider multiple participants speaking
    • see, if current speaking information available in stores can be reused
    • alternative: we should send the session id of the video stream source inside the PeerConnection through a DataChannel message. This will then be updated once the SIP bridge switches to a different speaker. I think there already exists one for the display name (nickChanged)
    • adjust components CallView >> VideoBottomBar

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions