test(files): make row action-menu lookup atomic to fix detached-DOM f…#61101
Draft
pringelmann wants to merge 1 commit into
Draft
test(files): make row action-menu lookup atomic to fix detached-DOM f…#61101pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
…lake Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
force-pushed
the
fix/cypress-files-action-menu-flake
branch
from
e695541 to
6b5f007
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Should make Files cypress tests a little less flaky 🤞
getActionEntryFor*in files test utils looked up the open row action menu in two steps. The menu is a teleportedNcActionspopover that re-renders, so the captured subject detaches and the chained.find()throws "subject is no longer attached to the DOM". This seems to be one of the most frequent cypress flakes on master, hitting files-renaming, files-copy-move, etc. etc.Change
Collapse the lookup into one atomic query so cypress retries the whole selector against the live DOM when the popover re-renders, instead of holding a stale subject.