Skip to content

fix(contacts): label app content regions #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hamza-agent wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −6
Open

fix(contacts): label app content regions #5375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/AppContent/ChartContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
- SPDX-License-Identifier: AGPL-3.0-or-later
-->
<template>
<AppContent>
<AppContent :aria-label="t('contacts', 'Organization chart')">
<OrgChart :data="transformData" />
</AppContent>
</template>
Expand Down
2 changes: 1 addition & 1 deletion src/components/AppContent/CircleContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
-->

<template>
<AppContent>
<AppContent :aria-label="t('contacts', 'Teams')">
<EmptyContent v-if="!circle && !userGroup" :name="t('contacts', 'Please select a team')">
<template #icon>
<AccountGroup :size="20" />
Expand Down Expand Up @@ -54,7 +54,7 @@
props: {
loading: {
type: Boolean,
default: true,

Check warning on line 57 in src/components/AppContent/CircleContent.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Boolean prop should only be defaulted to false
},
},

Expand Down
12 changes: 8 additions & 4 deletions src/components/AppContent/ContactsContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@
-->

<template>
<AppContent v-if="loading">
<AppContent v-if="loading" :aria-label="t('contacts', 'Contacts')">
<EmptyContent class="empty-content" :name="t('contacts', 'Loading contacts …')">
<template #icon>
<IconLoading :size="20" />
</template>
</EmptyContent>
</AppContent>

<AppContent v-else-if="isEmptyGroup && !isRealGroup">
<AppContent v-else-if="isEmptyGroup && !isRealGroup" :aria-label="t('contacts', 'Contacts')">
<EmptyContent class="empty-content" :name="t('contacts', 'There are no contacts yet')">
<template #icon>
<IconContact :size="20" />
Expand All @@ -25,7 +25,7 @@
</EmptyContent>
</AppContent>

<AppContent v-else-if="isEmptyGroup && isRealGroup">
<AppContent v-else-if="isEmptyGroup && isRealGroup" :aria-label="t('contacts', 'Contacts')">
<EmptyContent class="empty-content" :name=" t('contacts', 'There are no contacts in this group')">
<template #icon>
<IconContact :size="20" />
Expand All @@ -41,7 +41,11 @@
</EmptyContent>
</AppContent>

<AppContent v-else :show-details="showDetails" @update:show-details="hideDetails">
<AppContent
v-else
:aria-label="t('contacts', 'Contacts')"
:show-details="showDetails"
@update:show-details="hideDetails">
<!-- contacts list -->
<template #list>
<ContactsList
Expand Down Expand Up @@ -88,7 +92,7 @@
props: {
loading: {
type: Boolean,
default: true,

Check warning on line 95 in src/components/AppContent/ContactsContent.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

Boolean prop should only be defaulted to false
},

contactsList: {
Expand Down Expand Up @@ -157,7 +161,7 @@
* Forward the newContact event to the parent
*/
newContact() {
this.$emit('new-contact')

Check warning on line 164 in src/components/AppContent/ContactsContent.vue

View workflow job for this annotation

GitHub Actions / NPM lint 

The "new-contact" event has been triggered but not declared on `emits` option
},

/**
Expand Down
Loading