Skip to content

Apply rector changes #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nextcloud-command wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Apply rector changes #2492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
"rector": "rector && composer cs:fix"
},
"require-dev": {
"nextcloud/ocp": "dev-master",
"bamarni/composer-bin-plugin": "^1.8"
}
}
362 changes: 2 additions & 360 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/Activity/ProviderParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<?php

declare(strict_types=1);
Expand Down Expand Up @@ -71,7 +71,7 @@
foreach ($ak as $k) {
$subAk = array_keys($data[$k]);
foreach ($subAk as $sK) {
if (str_starts_with($sK, '_')) {
if (str_starts_with((string)$sK, '_')) {

Check failure on line 74 in lib/Activity/ProviderParser.php

View workflow job for this annotation

GitHub Actions / static-psalm-analysis

InvalidCast 

lib/Activity/ProviderParser.php:74:33: InvalidCast: key-of<array<array-key, mixed>> cannot be cast to string (see https://psalm.dev/103)
unset($data[$k][$sK]);
}
}
Expand Down
Loading
Loading