Comments doesn't work from ?announcement=xx urls.

[wizzardking]

Comment section doesn't work if jump to a specific announcement.

If a user came to the Announcement Center from a sent mail or from dashboard widget, the comment sections won't open.

Steps to reproduce

1. open the announcement center by adding the id of the announcement: https://url.com/apps/announcementcenter?announcement=10
2. Click on the "Comments" Button

Expected behaviour

The comment section should be displayed

Actual behaviour

Nothing happend. Announcement Center has to get opend without ?announcementer=xx on the url.

Server configuration

Tested with NC 26 & 27 on several different server configurations.

[nickvergessen]

So it seems to work sometimes, I guess the loading order of scripts or execution speed of some methods has an effect.

[nickvergessen]

I guess you don't have a development set up in which you could verify #697 ?

[wizzardking]

Thank you for your very quick reply and your commit.

So it seems to work sometimes
With "?announcementer=xx" in the URL, it never works in our setup (I assume since update to NC26). The comment section only works, if I visit the Announcement Center directly: https://xxx/apps/announcementcenter

I guess you don't have a development set up
Unfortunately, I don't have a test system set up and I don't know how to deploy the custom code to the production environment.

[almereyda]

I can replicate this behaviour:

Opening an announcement from the dashboard switches to the announcements view, but comments will be inactive. Unfotunately our announcements notification emails do not contain any links.

[decfreak]

Comment section doesn't work if jump to a specific announcement.

If a user came to the Announcement Center from a sent mail or from dashboard widget, the comment sections won't open.

Steps to reproduce

1. open the announcement center by adding the id of the announcement: https://url.com/apps/announcementcenter?announcement=10
2. Click on the "Comments" Button

Expected behaviour

The comment section should be displayed

Actual behaviour

Nothing happend. Announcement Center has to get opend without ?announcementer=xx on the url.

Server configuration

Tested with NC 26 & 27 on several different server configurations.

Can confirm the exact same behaviour in NC 28(.0.5)

[masterxq]

On nc 31.0.6 still open and very annoying. As this is the standard way to read comments from dashboard. Makes comments hard to use in production.

This should not be that hard to fix and has big impact for usability of the plugin...

[nickvergessen]

This might be fixed by #943 which changes the way the sidebar is handled. So try again after the next release