Skip to content

Dhasa year duration settings are not applied correctly in PyJHora 4.8.7 #62

Description

@denisflock-stack

In PyJHora 4.8.7, the dhasa year duration settings appear to be broken.

config.apply_setting() assigns string values from JSON directly to constants:

setattr(const, const_name, value)

For example, dhasa_year_duration_default becomes "GREGORIAN_YEAR", while drik.dhasa_year_duration() compares it with DHASA_YEAR_DURATION.GREGORIAN_YEAR (IntEnum). The comparison fails and the calculation falls back to the sidereal year.

There also appear to be two related issues:
savana_year_method_default is not used by dhasa_year_duration().
true_lunar_year_method_default is not applied correctly in true_tithi_year().

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions