Skip to content

Exception is thrown when Asset is missing required elements. #25

Description

@sdedios

If you're parsing an Asset that is missing required fields (e.g. file), then Contenfully will throw when it tries to transform the Asset to a Media object.

The specific issue sits in the line where you dereference an undefined file.url property, causing an unexpected / uncaught Error to be thrown.

I understand that this is definitely a content editing issue, but it's a tough bug to trace or defensively program against. It also probably only applies to preview environments where invalid data might be seen.

At a minimum, I would suggest:

  1. Provide better logging as per issue Add robust logging #23
  2. Do a runtime check and throw a clearer error for malformed assets

Additionally, it would be really nice if you had some type of option to prune / drop malformed assets from the results.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions