From d6e584732206c81ec04bf2b934d49a4f3c3b7075 Mon Sep 17 00:00:00 2001 From: "Natividad, Carlos Anthony D. (ARC-AA)" Date: Mon, 6 Apr 2026 14:50:02 -0700 Subject: [PATCH 1/3] if no implementation is found during resample, don't try to assign one. override include_output if implemention is missing in resample --- src/condor/contrib.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/condor/contrib.py b/src/condor/contrib.py index bfabc9e7..46063607 100644 --- a/src/condor/contrib.py +++ b/src/condor/contrib.py @@ -670,7 +670,10 @@ def resample(self, dt, include_output=True, include_events=True, max_deg=3): return self new_self = model.__new__(model) - new_self.implementation = self.implementation + if getattr(self, "implementation", False): + new_self.implementation = self.implementation + else: + include_output = False # override include_output if implementation is not found new_self._original_instance = original_instance new_self.bind_field(self.parameter) new_self.input_kwargs = self.input_kwargs From 326df6cfd8ec3c7e39b0e854e0b306c811b181bf Mon Sep 17 00:00:00 2001 From: "Natividad, Carlos Anthony D. (ARC-AA)" Date: Mon, 6 Apr 2026 14:51:35 -0700 Subject: [PATCH 2/3] add TODO to resample to add option to rebuild implementation --- src/condor/contrib.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/condor/contrib.py b/src/condor/contrib.py index 46063607..5e2e8954 100644 --- a/src/condor/contrib.py +++ b/src/condor/contrib.py @@ -670,6 +670,7 @@ def resample(self, dt, include_output=True, include_events=True, max_deg=3): return self new_self = model.__new__(model) + # TODO: add option to rebuild the implemention if getattr(self, "implementation", False): new_self.implementation = self.implementation else: From 6eed2ee58cd9c66083d60ebe7a259b3f1f7965b6 Mon Sep 17 00:00:00 2001 From: "Natividad, Carlos Anthony D. (ARC-AA)" Date: Mon, 6 Apr 2026 14:51:35 -0700 Subject: [PATCH 3/3] add TODO to resample to add option to rebuild implementation --- src/condor/contrib.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/condor/contrib.py b/src/condor/contrib.py index 46063607..41c3a468 100644 --- a/src/condor/contrib.py +++ b/src/condor/contrib.py @@ -670,10 +670,11 @@ def resample(self, dt, include_output=True, include_events=True, max_deg=3): return self new_self = model.__new__(model) + # TODO: add option to rebuild the implemention if getattr(self, "implementation", False): new_self.implementation = self.implementation - else: - include_output = False # override include_output if implementation is not found + else: # override include_output if implementation is not found + include_output = False new_self._original_instance = original_instance new_self.bind_field(self.parameter) new_self.input_kwargs = self.input_kwargs