Invocation of removed method NativeEventEmitter.removeListener causes exception/crash

[elia-ba]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch react-native-safari-view@2.1.0 for the project I'm working on.

NativeEventEmitter.removeListener has been removed since a few version in React Native, instead you are supposed to call the .remove() on the returned "listenere" which is an event subscription now.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-safari-view/SafariViewManager.ios.js b/node_modules/react-native-safari-view/SafariViewManager.ios.js
index d2c0042..4e9ad11 100644
--- a/node_modules/react-native-safari-view/SafariViewManager.ios.js
+++ b/node_modules/react-native-safari-view/SafariViewManager.ios.js
@@ -46,9 +46,9 @@ export default {
 
   removeEventListener(event, listener) {
     if (event === 'onShow') {
-      eventEmitter.removeListener('SafariViewOnShow', listener);
+    	listener.remove();
     } else if (event === 'onDismiss') {
-      eventEmitter.removeListener('SafariViewOnDismiss', listener);
+    	listener.remove();
     }
   }
 };

This issue body was partially generated by patch-package.