An instance of #503's class, not a new report of it. #503 owns the structural
problem (windows-msvc-* are PR-only, so main-baseline.py reports GREEN because
it never runs them) and #603 names the setenv/unsetenv instance. This is a
second, distinct instance in a different file.
What
src/vllm/multimodal/video_engine.cpp includes <sys/stat.h> unguarded, and the
Windows gate flags three sites:
ERROR: src/vllm/multimodal/video_engine.cpp:21: unguarded POSIX include/call reaches Windows
ERROR: src/vllm/multimodal/video_engine.cpp:59: unguarded POSIX include/call reaches Windows
ERROR: src/vllm/multimodal/video_engine.cpp:64: unguarded POSIX include/call reaches Windows
Present on main at 22367c551; the file landed in cefacd2d0 (LTX-2.5,
#435 / #641). Verified as pre-existing: the three sites are in
git show origin/main:src/vllm/multimodal/video_engine.cpp, and the PR that
surfaced it (#705) is records-only with no C++ in its diff.
Fix
Guard the include and the two call sites behind the platform seam the rest of the
tree uses. The "why did this land green" half belongs to #503 and is not
restated here.
An instance of #503's class, not a new report of it. #503 owns the structural
problem (windows-msvc-* are PR-only, so
main-baseline.pyreports GREEN becauseit never runs them) and #603 names the
setenv/unsetenvinstance. This is asecond, distinct instance in a different file.
What
src/vllm/multimodal/video_engine.cppincludes<sys/stat.h>unguarded, and theWindows gate flags three sites:
Present on
mainat22367c551; the file landed incefacd2d0(LTX-2.5,#435 / #641). Verified as pre-existing: the three sites are in
git show origin/main:src/vllm/multimodal/video_engine.cpp, and the PR thatsurfaced it (#705) is records-only with no C++ in its diff.
Fix
Guard the include and the two call sites behind the platform seam the rest of the
tree uses. The "why did this land green" half belongs to #503 and is not
restated here.