Defect
Current main at cefacd2d00cb9b4776331cd213116773cd97f811 adds three LTX2 source files containing M_PI. The existing Windows portability regression test rejects those tokens because MSVC does not expose M_PI by default.
Affected files:
src/vllm/model_executor/models/ltx2.cppsrc/vllm/model_executor/models/ltx2_video_vae.cppsrc/vllm/model_executor/models/ltx2_audio_vae.cpp
Reproduction
python3 -m unittest tests.scripts.test_check_windows_portability.WindowsPortabilityCheckerTest.test_real_tree_uses_portable_windows_allocation_and_math
FAIL: offenders = [the three files above]
Required outcome
Replace the platform macro with a standard C++ constant without weakening or exempting the portability detector. Preserve the LTX2 numerics and pass the focused Windows portability test plus the release gate.
This regression blocks the Windows binary release work in PR #524.
Defect
Current
mainatcefacd2d00cb9b4776331cd213116773cd97f811adds three LTX2 source files containingM_PI. The existing Windows portability regression test rejects those tokens because MSVC does not exposeM_PIby default.Affected files:
src/vllm/model_executor/models/ltx2.cppsrc/vllm/model_executor/models/ltx2_video_vae.cppsrc/vllm/model_executor/models/ltx2_audio_vae.cppReproduction
Required outcome
Replace the platform macro with a standard C++ constant without weakening or exempting the portability detector. Preserve the LTX2 numerics and pass the focused Windows portability test plus the release gate.
This regression blocks the Windows binary release work in PR #524.