Pontoon adds NUMBER() function when saving translation

[flodolo]

CC @bcolsson and @eemeli

I haven't figured out the exact steps, but Pontoon is sometimes adding the NUMBER() function around a variable, when the source doesn't have any. This has proven problematic in the past.

This is the group of strings, but I haven't been able to replicate on this locale
https://pontoon.mozilla.org/af/firefox/browser/browser/browser.ftl/?search_identifiers=true&search_exclude_source_strings=true&search=urlbar-result-explanation-last-visited-&string=335545

On other hand, it happened with several locales while trying to fix the wrong variable (example).

See also mozilla-l10n/firefox-l10n@a82663a

[bcolsson]

Confirming this is happening for multiple locales: mozilla-l10n/firefox-l10n@227cb3a

[flodolo]

Filed mozilla/moz-l10n#157, although I'm not completely sure if that's the cause.

[flodolo]

I think I reproduced it finally.
https://pontoon.mozilla.org/af/firefox/browser/browser/browser.ftl/?search_identifiers=true&search_exclude_source_strings=true&search=urlbar-result-explanation-last-visited-&string=335545

1. Submit translation/suggestion with the wrong variable
2. Reload
3. Submit translation/suggestion with the correct variable

So, it only happens when there's a wrong variable first, not when translated directly. This might be indeed caused by the issue I filed in moz-l10n then.

[bcolsson]

I think I reproduced it finally. https://pontoon.mozilla.org/af/firefox/browser/browser/browser.ftl/?search_identifiers=true&search_exclude_source_strings=true&search=urlbar-result-explanation-last-visited-&string=335545

1. Submit translation/suggestion with the wrong variable

2. Reload

3. Submit translation/suggestion with the correct variable

So, it only happens when there's a wrong variable first, not when translated directly. This might be indeed caused by the issue I filed in moz-l10n then.

Confirmed this happened when correcting an incorrect variable in this string:
https://pontoon.mozilla.org/sk/firefox/all-resources/?search_identifiers=true&search=urlbar-result-explanation-last-visited-months&string=335547