Skip to content

Commit e0ef65c

Browse files
authored
use AWS' aws-nitro-enclaves-image-format instead of maintaining our own CLI fork (#24)
Thanks to aws/aws-nitro-enclaves-image-format#27 , we can now build EIFs via a low-level CLI that uses `aws-nitro-enclave-image-format` directly, rather than maintaining and developing our own CLI (which was forked from an old example in that repo anyway). For us, this means we can remove all the Rust code in this repository and defer to AWS. So this PR: - packages AWS' `eif_build` with Nix to use as build dependency - replaces `eif-cli` with `eif_build`, removing `eif-cli` altogether - fixes outdated code comment and flake description - adds a Cargo.lock to lock upstream's dependencies. This is needed to reproducibly build `eif_build`. We can remove it in the future if aws/aws-nitro-enclaves-image-format#34 is closed. **Note EIFs built after this PR are not bit-by-bit identical to the ones built before this PR** (so they will not have the same SHA256 digests). This is because the EIF metadata has been updated too. PCRs, on the other hand, can be expected to remain the same (because metadata is not included in PCR0 hashing). We assert this via our [flake check](https://github.com/monzo/aws-nitro-util/actions/runs/10558127694/job/29246984165?pr=24) , which builds a test EIF against a hardcoded PCR0. As far as downstream users are concerned, this PR has no other breaking changes.
1 parent ac2152c commit e0ef65c

6 files changed

Lines changed: 352 additions & 469 deletions

File tree

eif-cli/Cargo.toml

Lines changed: 0 additions & 17 deletions
This file was deleted.

eif-cli/src/main.rs

Lines changed: 0 additions & 298 deletions
This file was deleted.

0 commit comments

Comments
 (0)