Skip to content

fix: close prior REPL websocket on reconnect to stop duplicated output #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tehn merged 1 commit into from
May 20, 2026
Merged

fix: close prior REPL websocket on reconnect to stop duplicated output #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion web/src/model/repl-actions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,24 @@ export const replEndpoints = cb => dispatch => {
});
};

export const replConnect = (component, endpoint, retryCount) => dispatch => {
export const replDisconnect = (component) => (dispatch, getState) => {
const existing = getState().repl.connections.get(component);
if (!existing) return;
const socket = existing.get('socket');
if (socket) {
// detach handlers so that an orphaned connection's late onclose doesn't
// clobber the new socket's state
socket.onopen = null;
socket.onerror = null;
socket.onclose = null;
socket.onmessage = null;
socket.close();
}
dispatch(replConnectClose(component));
};

export const replConnect = (component, endpoint, retryCount) => (dispatch, getState) => {
dispatch(replDisconnect(component));
dispatch(replConnectDial(component, endpoint));
const socket = new WebSocket(endpoint, ['bus.sp.nanomsg.org']);
socket.onopen = () => {
Expand Down
Loading