From d99a5406176b6239eec219be427b1a9a66050388 Mon Sep 17 00:00:00 2001 From: monkut Date: Tue, 28 Apr 2026 16:22:27 +0900 Subject: [PATCH 1/3] :bug: Require AC + Dependencies headings in plan prompt (closes #96) --- askcc/definitions.py | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/askcc/definitions.py b/askcc/definitions.py index a9bb51a..c298330 100644 --- a/askcc/definitions.py +++ b/askcc/definitions.py @@ -152,17 +152,26 @@ (e.g., answers to prepare-step questions). Rewrite the issue body to be development-ready: `gh issue edit --body ""`. \ -The body should define what needs to be built, incorporating decisions from comments. Include: - -1. **Acceptance Criteria** — replace any existing `## Acceptance Criteria` section \ -(including `` variants) with a finalized `## Acceptance Criteria` `- [ ]` checklist \ -derived from your plan. -2. **Dependencies** — replace any existing `## Dependencies` section (including `` \ -variants) with a finalized list. If none, include the heading with "None identified." +The body MUST contain all of the following sections — add any that are missing: + +1. **Acceptance Criteria** — the body MUST contain a `## Acceptance Criteria` heading with at \ +least one `- [ ]` checklist item derived from your plan. If a section exists (including \ +`` variants), replace it; otherwise add it. Rename non-canonical headings like \ +`## Tasks` or `## Requirements` to `## Acceptance Criteria` rather than leaving them. +2. **Dependencies** — the body MUST contain a `## Dependencies` heading. Replace any existing \ +one (including `` variants); if none exists, add it with "None identified." 3. **Implementation Plan** — add `## Implementation Plan` with step-by-step tasks referencing \ specific files and functions. 4. **Assignee** — assign to the authenticated user: `gh issue edit --add-assignee "@me"`. +## Post-Update Verification + +After editing, re-read the body (`gh issue view --json body -q .body`) and confirm it \ +contains both a `## Acceptance Criteria` heading with at least one `- [ ]` checklist item AND a \ +`## Dependencies` (or Prerequisites/Context/Blockers) heading. If either check fails, re-edit \ +the body and re-verify. Do not stop until both are present — `develop` will reject the issue \ +otherwise. + ## Summary Comment After updating the description, comment on the issue summarizing: From 334bd46a8d1a00ce4ab3b47df1ce4350e57139a5 Mon Sep 17 00:00:00 2001 From: monkut Date: Tue, 28 Apr 2026 16:30:05 +0900 Subject: [PATCH 2/3] :art: Tighten plan-prompt body-update wording --- askcc/definitions.py | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/askcc/definitions.py b/askcc/definitions.py index c298330..d61db8e 100644 --- a/askcc/definitions.py +++ b/askcc/definitions.py @@ -154,23 +154,23 @@ Rewrite the issue body to be development-ready: `gh issue edit --body ""`. \ The body MUST contain all of the following sections — add any that are missing: -1. **Acceptance Criteria** — the body MUST contain a `## Acceptance Criteria` heading with at \ -least one `- [ ]` checklist item derived from your plan. If a section exists (including \ -`` variants), replace it; otherwise add it. Rename non-canonical headings like \ -`## Tasks` or `## Requirements` to `## Acceptance Criteria` rather than leaving them. -2. **Dependencies** — the body MUST contain a `## Dependencies` heading. Replace any existing \ -one (including `` variants); if none exists, add it with "None identified." -3. **Implementation Plan** — add `## Implementation Plan` with step-by-step tasks referencing \ +1. **Acceptance Criteria** — `## Acceptance Criteria` heading with at least one `- [ ]` \ +checklist item derived from your plan. Replace any existing section (including `` \ +variants); rename non-canonical headings like `## Tasks` or `## Requirements`. +2. **Dependencies** — `## Dependencies` heading. Replace any existing section (including \ +`` variants); if none, use "None identified." +3. **Implementation Plan** — `## Implementation Plan` with step-by-step tasks referencing \ specific files and functions. -4. **Assignee** — assign to the authenticated user: `gh issue edit --add-assignee "@me"`. +4. **Assignee** — assign the authenticated user: `gh issue edit --add-assignee "@me"`. + +Keep prose concise; prefer bullet lists over paragraphs. ## Post-Update Verification -After editing, re-read the body (`gh issue view --json body -q .body`) and confirm it \ -contains both a `## Acceptance Criteria` heading with at least one `- [ ]` checklist item AND a \ -`## Dependencies` (or Prerequisites/Context/Blockers) heading. If either check fails, re-edit \ -the body and re-verify. Do not stop until both are present — `develop` will reject the issue \ -otherwise. +Re-read the body (`gh issue view --json body -q .body`) and confirm both \ +`## Acceptance Criteria` (with a `- [ ]` checklist item) and `## Dependencies` (or \ +Prerequisites/Context/Blockers) headings are present. Re-edit and re-verify until both pass — \ +`develop` rejects the issue otherwise. ## Summary Comment From c84865fa381568f4b50f02d0c00d98132e40541c Mon Sep 17 00:00:00 2001 From: monkut Date: Tue, 28 Apr 2026 16:32:27 +0900 Subject: [PATCH 3/3] :bookmark: Bump version to 0.2.10 --- pyproject.toml | 2 +- uv.lock | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index e273180..47bdc41 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [project] name = "askcc" -version = "0.2.9" +version = "0.2.10" description = "A one-shot cc cli executor" authors = [{ name = "mknt", email = "shane.cousins@gmail.com" }] readme = "README.md" diff --git a/uv.lock b/uv.lock index c9780e4..70fa014 100644 --- a/uv.lock +++ b/uv.lock @@ -4,7 +4,7 @@ requires-python = "==3.14.*" [[package]] name = "askcc" -version = "0.2.9" +version = "0.2.10" source = { editable = "." } [package.dev-dependencies]