From 8cdb15e31d5eae0d3f4e4f20cf1af4c94038f35a Mon Sep 17 00:00:00 2001 From: monkut Date: Fri, 8 May 2026 11:43:15 +0900 Subject: [PATCH] :bug: Verify assignee in plan post-update verification (closes #106) Closes the contract gap between `askcc plan` and `askcc develop` for the assignee check, mirroring the AC/Dependencies fix from #96. The plan prompt instructs `gh issue edit --add-assignee "@me"`, but the post-update verification loop only checked AC + Dependencies headings, so a missed assignee step produced a silent failure mode where develop's validate_issue_readiness rejected the issue. The verification block now fetches both `body` and `assignees` via a single `gh issue view --json body,assignees` call and re-assigns / re-edits until all three plan-controllable readiness checks pass. --- askcc/definitions.py | 8 ++++---- pyproject.toml | 2 +- uv.lock | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/askcc/definitions.py b/askcc/definitions.py index a6d89eb..ed1f603 100644 --- a/askcc/definitions.py +++ b/askcc/definitions.py @@ -167,10 +167,10 @@ ## Post-Update Verification -Re-read the body (`gh issue view --json body -q .body`) and confirm both \ -`## Acceptance Criteria` (with a `- [ ]` checklist item) and `## Dependencies` (or \ -Prerequisites/Context/Blockers) headings are present. Re-edit and re-verify until both pass — \ -`develop` rejects the issue otherwise. +Re-read the body and assignees (`gh issue view --json body,assignees`) and confirm \ +(a) `## Acceptance Criteria` heading with a `- [ ]` checklist item, (b) `## Dependencies` (or \ +Prerequisites/Context/Blockers) heading is present, and (c) at least one assignee is set. \ +Re-edit / re-assign and re-verify until all three pass — `develop` rejects the issue otherwise. ## Summary Comment diff --git a/pyproject.toml b/pyproject.toml index c846016..ed6d0a4 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,6 +1,6 @@ [project] name = "askcc" -version = "0.2.12" +version = "0.2.13" description = "A one-shot cc cli executor" authors = [{ name = "mknt", email = "shane.cousins@gmail.com" }] readme = "README.md" diff --git a/uv.lock b/uv.lock index 177f36d..d1c213b 100644 --- a/uv.lock +++ b/uv.lock @@ -4,7 +4,7 @@ requires-python = "==3.14.*" [[package]] name = "askcc" -version = "0.2.12" +version = "0.2.13" source = { editable = "." } [package.dev-dependencies]