Skip to content

Commit d6863a4

Browse files
committed
common: cloudprotocol: align request log message with protocol
This patch aligns the request log message with the cloud protocol: - Upload options are moved out from the log filter to the request log message; - Log type is changed to log upload type in the upload options struct. Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
1 parent b50b274 commit d6863a4

1 file changed

Lines changed: 32 additions & 7 deletions

File tree

  • include/aos/common/cloudprotocol

include/aos/common/cloudprotocol/log.hpp

Lines changed: 32 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,35 @@ class LogTypeType {
5555
using LogTypeEnum = LogTypeType::Enum;
5656
using LogType = EnumStringer<LogTypeType>;
5757

58+
/**
59+
* Log upload type type.
60+
*/
61+
class LogUploadTypeType {
62+
public:
63+
enum class Enum {
64+
eAMQPS,
65+
eHTTPS,
66+
};
67+
68+
static const Array<const char* const> GetStrings()
69+
{
70+
static const char* const sStrings[] = {
71+
"amqps",
72+
"https",
73+
};
74+
75+
return Array<const char* const>(sStrings, ArraySize(sStrings));
76+
};
77+
};
78+
79+
using LogUploadTypeEnum = LogUploadTypeType::Enum;
80+
using LogUploadType = EnumStringer<LogUploadTypeType>;
81+
5882
/**
5983
* Log upload options.
6084
*/
6185
struct LogUploadOptions {
62-
LogType mType;
86+
LogUploadType mType;
6387
StaticString<cURLLen> mURL;
6488
StaticString<cBearerTokenLen> mBearerToken;
6589
Optional<Time> mBearerTokenTTL;
@@ -92,7 +116,6 @@ struct LogFilter {
92116
Optional<Time> mFrom;
93117
Optional<Time> mTill;
94118
StaticArray<StaticString<cNodeIDLen>, cMaxNumNodes> mNodeIDs;
95-
Optional<LogUploadOptions> mUploadOptions;
96119
InstanceFilter mInstanceFilter;
97120

98121
/**
@@ -104,7 +127,7 @@ struct LogFilter {
104127
bool operator==(const LogFilter& filter) const
105128
{
106129
return mFrom == filter.mFrom && mTill == filter.mTill && mNodeIDs == filter.mNodeIDs
107-
&& mUploadOptions == filter.mUploadOptions && mInstanceFilter == filter.mInstanceFilter;
130+
&& mInstanceFilter == filter.mInstanceFilter;
108131
}
109132

110133
/**
@@ -120,9 +143,10 @@ struct LogFilter {
120143
* Log status.
121144
*/
122145
struct RequestLog {
123-
StaticString<cLogIDLen> mLogID;
124-
LogType mLogType;
125-
LogFilter mFilter;
146+
StaticString<cLogIDLen> mLogID;
147+
LogType mLogType;
148+
LogFilter mFilter;
149+
Optional<LogUploadOptions> mUploadOptions;
126150

127151
/**
128152
* Compares log request.
@@ -132,7 +156,8 @@ struct RequestLog {
132156
*/
133157
bool operator==(const RequestLog& request) const
134158
{
135-
return mLogID == request.mLogID && mLogType == request.mLogType && mFilter == request.mFilter;
159+
return mLogID == request.mLogID && mLogType == request.mLogType && mFilter == request.mFilter
160+
&& mUploadOptions == request.mUploadOptions;
136161
}
137162

138163
/**

0 commit comments

Comments
 (0)