Skip to content

Commit 1c40800

Browse files
msiebertclaude
andcommitted
Remove report_exposure parameter from OpenFeature provider's get_variant call
Let the underlying flags provider use its default behavior rather than explicitly passing report_exposure=True. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent e601641 commit 1c40800

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

openfeature-provider/src/mixpanel_openfeature/provider.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def _resolve(
108108
user_context = self._build_user_context(evaluation_context)
109109
try:
110110
result = self._flags_provider.get_variant(
111-
flag_key, fallback, user_context, report_exposure=True
111+
flag_key, fallback, user_context
112112
)
113113
except Exception:
114114
return FlagResolutionDetails(

openfeature-provider/tests/test_provider.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def provider(mock_flags):
2323
def setup_flag(mock_flags, flag_key, value, variant_key="variant-key"):
2424
"""Configure mock to return a SelectedVariant with the given value."""
2525
mock_flags.get_variant.side_effect = (
26-
lambda key, fallback, ctx, report_exposure=True: (
26+
lambda key, fallback, ctx: (
2727
SelectedVariant(variant_key=variant_key, variant_value=value)
2828
if key == flag_key
2929
else fallback
@@ -34,7 +34,7 @@ def setup_flag(mock_flags, flag_key, value, variant_key="variant-key"):
3434
def setup_flag_not_found(mock_flags, flag_key):
3535
"""Configure mock to return the fallback (identity check triggers FLAG_NOT_FOUND)."""
3636
mock_flags.get_variant.side_effect = (
37-
lambda key, fallback, ctx, report_exposure=True: fallback
37+
lambda key, fallback, ctx: fallback
3838
)
3939

4040

@@ -300,7 +300,7 @@ def test_provider_not_ready_object(mock_flags):
300300
def test_remote_provider_always_ready():
301301
remote_flags = MagicMock(spec=[]) # empty spec = no attributes
302302
remote_flags.get_variant = MagicMock(
303-
side_effect=lambda key, fallback, ctx, report_exposure=True: SelectedVariant(
303+
side_effect=lambda key, fallback, ctx: SelectedVariant(
304304
variant_key="v1", variant_value=True
305305
)
306306
)

0 commit comments

Comments
 (0)