Skip to content

Robot name capitalization inconsistencies on Robot carrousel page #19

Description

@SuperJappie08

On the website, there are some inconsistencies in MIRTE 'Type' capitalization in both the button and the alt-text of the image.

Affected

It affects the following pages/elements:

Exact discrepencies

The following things are inconsistent:

  • The alt-text of the image does not get resolved. (Copied from the deployed website source)
<div style="flex-grow: 1;" class="img-wrap">
    <img src="https://mirte.org/_nuxt/MIRTE_pioneer_transparant.DmXqtoRr.png" alt="MIRTE {{ robot }}">
</div>
  • The button does not capitalize the MIRTE Type correctly. (Copied example from deployment)
<a href="/steps?robot=pioneer" class="">
    <button class="btn my-button">Get started with <span class="mirte">MIRTE</span> <b>pioneer</b>!</button>
</a>

Here Pioneer should be capitalized as in most other instances.

Cause

It is related to the MyComponent.
Which capitalizes the text in some instances correctly.

This is the specific section:

<img :src="image[robot]" alt="MIRTE {{ robot }}">
</div>
<div>
<h5>MIRTE {{ robot.charAt(0).toUpperCase() + robot.slice(1) }}</h5>
<p style="margin: auto; max-width: 500px; margin-bottom: 50px;" >{{ $t(`robots.${robot}`) }}</p>
<NuxtLink v-if="robot !== 'master'" :to="{ path: '/steps', query: { robot: robot } }" ><button class="btn my-button">{{ $t("robots.start") }} <span class="mirte">MIRTE</span> <b>{{robot}}</b>!</button></NuxtLink>
<a v-if="robot === 'master'" href="https://docs.mirte.org/develop/doc/robots/mirte_master/index.html" target="_blank" rel="noopener noreferrer"><button class="btn my-button"><span class="mirte">MIRTE</span> <b>master</b> docs</button></a>

Suggestion

I either make a capitalization function or capitalize once and store this in a variable that is reused in this component.
(I don't have experience with VUE, so I'm not sure what the best solution actually is)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions