Org-mode tags in org-modern-tag-faces get spell-checked

[andersjohansson]

Hi,

Tags that are listed in org-modern-tag-faces get a face definition that is not excluded by the rules in jinx-exclude-faces.

If I do:

(setq org-modern-tag-faces   '(("ignoreheading" modus-themes-nuanced-blue)))

An "ignoreheading" tag gets the face:

(:inherit ((modus-themes-nuanced-blue) org-modern-tag))

And this is not matched in jinx--face-excluded-p.

I also tried doing this for all the faces I added to org-modern-tag-faces:

(cl-pushnew '(:inherit (modus-themes-nuanced-blue) org-modern-tag)
                        (alist-get 'org-mode jinx-exclude-faces))
            (add-to-list 'org-modern-tag-faces (list name face))

But this doesn’t match since it won’t be eq (but it is equal). Extracting the central check in jinx--face-excluded-p, this returns nil:

(memq '(:inherit ((modus-themes-nuanced-blue) org-modern-tag))
       (alist-get 'org-mode jinx-exclude-faces))

I don’t know what a smart solution for this would be, but since both packages are yours I gather you can come to a good decision (or decide to just not support this case, which could also be reasonable).