From 984e34e7db826f6945b1566509400025f4a3d06b Mon Sep 17 00:00:00 2001 From: Min Huang <70873102+min0625@users.noreply.github.com> Date: Tue, 21 Apr 2026 17:41:15 +0000 Subject: [PATCH] chore: improve linting configuration and dev tooling --- .devcontainer/post_create.sh | 2 ++ .github/workflows/pr-check.yml | 6 +++--- .golangci.yaml | 2 -- AGENTS.md | 2 +- Makefile | 12 +++++++++--- 5 files changed, 15 insertions(+), 9 deletions(-) diff --git a/.devcontainer/post_create.sh b/.devcontainer/post_create.sh index cf64f30..a190145 100644 --- a/.devcontainer/post_create.sh +++ b/.devcontainer/post_create.sh @@ -9,5 +9,7 @@ mise trust . mise install +mise exec -- go mod download + mise exec -- go install -v golang.org/x/tools/gopls@latest mise exec -- go install -v github.com/go-delve/delve/cmd/dlv@latest diff --git a/.github/workflows/pr-check.yml b/.github/workflows/pr-check.yml index 14c92c5..29e78aa 100644 --- a/.github/workflows/pr-check.yml +++ b/.github/workflows/pr-check.yml @@ -7,7 +7,7 @@ on: jobs: check: - name: Lint & Test + name: Check runs-on: ubuntu-latest steps: - name: Checkout @@ -21,5 +21,5 @@ jobs: - name: Download Go dependencies run: go mod download - - name: Run check (lint + test) - run: make check + - name: Run check + run: make check NEW_FROM_REV=origin/${{ github.base_ref }} diff --git a/.golangci.yaml b/.golangci.yaml index 8891809..eb3c803 100644 --- a/.golangci.yaml +++ b/.golangci.yaml @@ -5,9 +5,7 @@ run: timeout: 5m issues: - new: true whole-files: true - new-from-rev: HEAD~ max-same-issues: 50 severity: diff --git a/AGENTS.md b/AGENTS.md index 1a7c8fe..11adccf 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -26,7 +26,7 @@ make lint make fix # golangci-lint run -v --fix ./... -# Run lint + test together +# Run all checks make check ``` diff --git a/Makefile b/Makefile index 17d5bcf..78bf91e 100644 --- a/Makefile +++ b/Makefile @@ -1,10 +1,16 @@ +NEW_FROM_REV ?= HEAD + fix: - golangci-lint run -v --fix ./... + go mod tidy + golangci-lint run -v --new-from-rev=$(NEW_FROM_REV) --fix ./... lint: - golangci-lint run -v ./... + golangci-lint run -v --new-from-rev=$(NEW_FROM_REV) ./... test: go test -v -race -failfast ./... -check: lint test +check-tidy: + go mod tidy -diff + +check: check-tidy lint test