Skip to content

mssql-js: neither yarn lint nor yarn format:check runs in CI #267

Description

Describe the bug

The repo checklist for mssql-js lists yarn lint and yarn format:check, but neither runs in CI. Both scripts exist in mssql-js/package.json; CI just never invokes them.

.pipeline/scripts/containerized-js-build.sh (the only place JS is built in CI):

cd mssql-js
yarn install
yarn build
ls lib/generated
# echo "Check for formatting"
# yarn format:check      # <-- commented out, line 18
echo "Compiling Typescript files"
yarn buildapi

.pipeline/scripts/containerized-js-test.sh runs only yarn testci. So:

Check Script exists Runs in CI
yarn build yes yes
yarn buildapi (tsc) yes yes
yarn testci yes yes (PR builds only)
yarn format:check yes no — commented out
yarn lint yes no — never invoked

format:check being commented out is at least visible in the diff. lint is the quieter gap: it appears in no pipeline script at all, so eslint . --ext .ts,.js --max-warnings=0 is effectively unenforced despite --max-warnings=0 implying it is a gate.

Steps to reproduce

  1. grep -rn "format:check\|lint" .pipeline/scripts/
  2. Only hit is the commented-out line 18 of containerized-js-build.sh.
  3. Confirm both scripts are defined in mssql-js/package.json.

Expected behavior

Prettier and ESLint are enforced on PR builds, matching the documented contributor checklist — or the checklist is amended to say they are local-only.

Actual behavior

Neither runs. TypeScript/JS formatting and lint regressions can land without CI objecting.

Version

main @ e40e779d

Affected crate

mssql-js

Additional context

Found while validating #264 (a Rust-only change — all 14 changed files are .rs, zero JS surface). Not caused by that PR and not a blocker for it; filing so it is not lost.

Note there is a plausible reason format:check was disabled rather than merely forgotten — it may have been failing on generated output, since yarn build writes into lib/generated before the check would run, and the format:check glob "lib/**/*.ts" covers that directory. If so, the fix is likely to scope the glob away from generated files rather than to simply uncomment the line. lint has no such excuse.

Whoever picks this up should re-enable the two checks in one PR and fix whatever they surface, rather than uncommenting blindly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions