From f15eb9ce2aa64b981990a371bea30059aeb0f80d Mon Sep 17 00:00:00 2001 From: Changho Hwang Date: Thu, 11 Jun 2026 16:33:17 +0000 Subject: [PATCH 1/2] Add BASE_IMAGE override comments to Dockerfiles Explain that ARG BASE_IMAGE defaults exist for standalone docker build and that build.sh overrides them via --build-arg. --- docker/base-dev-x.dockerfile | 3 +++ docker/base-x.dockerfile | 2 ++ 2 files changed, 5 insertions(+) diff --git a/docker/base-dev-x.dockerfile b/docker/base-dev-x.dockerfile index 5c0a3192e..f7646807e 100644 --- a/docker/base-dev-x.dockerfile +++ b/docker/base-dev-x.dockerfile @@ -1,3 +1,6 @@ +# Default BASE_IMAGE allows standalone `docker build`. +# When using build.sh, this is overridden via --build-arg +# with the target-specific base image (e.g. ark:base-cuda12.1). ARG BASE_IMAGE=ghcr.io/microsoft/ark/ark:base-cuda12.1 FROM ${BASE_IMAGE} diff --git a/docker/base-x.dockerfile b/docker/base-x.dockerfile index c5ff03afe..52a7d267e 100644 --- a/docker/base-x.dockerfile +++ b/docker/base-x.dockerfile @@ -1,3 +1,5 @@ +# Default BASE_IMAGE allows standalone `docker build`. +# build.sh overrides this via --build-arg for each target. ARG BASE_IMAGE=nvidia/cuda:12.1.1-devel-ubuntu20.04 FROM ${BASE_IMAGE} From bfe9f0a823bd6f6e2a3bd12f897cd3a5f4ec4ad7 Mon Sep 17 00:00:00 2001 From: ark-dev Date: Thu, 11 Jun 2026 16:50:11 +0000 Subject: [PATCH 2/2] =?UTF-8?q?ark-dev:=20Continue=20P12:=20dev+local-test?= =?UTF-8?q?=20passed=20last=20cycle;=20improve/verify=20failed=20on=20deep?= =?UTF-8?q?-review=20infra=20(temp=20repo=20missing=20CMakeLists.txt),=20n?= =?UTF-8?q?ot=20code.=20Dockerfile=20comment=20changes=20are=20in=20workin?= =?UTF-8?q?g=20tree.=20Commit,=20push=20pr-k-docker-pkgs,=20and=20open=20P?= =?UTF-8?q?R=20against=20main.=20Skip=20deep-review=20=E2=80=94=20Dockerfi?= =?UTF-8?q?le-only=20change,=20no=20Docker=20CI;=20infra=20bug=20tracked?= =?UTF-8?q?=20as=20P14.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- docker/base-dev-x.dockerfile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docker/base-dev-x.dockerfile b/docker/base-dev-x.dockerfile index f7646807e..87c7aa9db 100644 --- a/docker/base-dev-x.dockerfile +++ b/docker/base-dev-x.dockerfile @@ -1,6 +1,5 @@ # Default BASE_IMAGE allows standalone `docker build`. -# When using build.sh, this is overridden via --build-arg -# with the target-specific base image (e.g. ark:base-cuda12.1). +# build.sh overrides this via --build-arg for each target. ARG BASE_IMAGE=ghcr.io/microsoft/ark/ark:base-cuda12.1 FROM ${BASE_IMAGE}