Scroll node into view - sometimes missed

[michael]

There are still situations, where a node is selected (that is out of view completely)

Reproduce:

• Select the "Minimal viable editor" story node
• Delete it
• Scroll to the bottom of the page
• Undo (node selection is not revealed on screen)

node-scroll-into-view-issue.mov

In a similar situation it's scrolling "very close" to the node, but still not making it visible.

Similar reproduction:

• Select the "Nested nodes" story node
• Delete it
• Scroll to the bottom of the page
• Undo (node selection is not revealed on screen)

node-scroll-into-view-issue-2.mov

Hard to say what the difference in these two situations is (like why is it off more in the first situation). Maybe a timing issue. However I think this is the last UX issue related to "node scrolls" - we're close.

[michael]

With collapsed node cursors there are similar issues. Try this:

• select the last node gap in body
• press backspace 10 times, making short breaks in betweeen

=> sometimes the blinking node cursor is revealed (right at the edge), sometimes not.

[johannesmutter]

Reproduce:

• Select the "Minimal viable editor" story node
• Delete it
• Scroll to the bottom of the page
• Undo (node selection is not revealed on screen)

fixed in #290

With collapsed node cursors there are similar issues. Try this:

• select the last node gap in body
• press backspace 10 times, making short breaks in betweeen

=> sometimes the blinking node cursor is revealed (right at the edge), sometimes not.

Fixed in #290

[johannesmutter]

The remaining multi-node case from (select-all buttons → delete → scroll away → undo) turned out to be a separate, deeper bug from the fixes in this PR, so I'm putting it now on its own branch: fix/node-scroll-after-relayout. It's a timing issue.

[johannesmutter]

Fixed via: #291