Add bittrex Config#1
Open
Varunram wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the config part, sadly I don't think I have the luxury to write handlers as well. The primary difference between Vertpig and Bittrex is that Bittrex returns floats for suitable values whereas vertpig returns strings. I tested all the public API endpoints and they do work, but further testing is most certainly needed, the functions without handlers need polishing and may have bugs.
I suggest this not be merged - instead someone can work on this to build the handlers instead of spending time again to write the config. I chose to build these because I was handling something related, maybe something similar can happen to someone else too :)