From 462472a5931d032f531244135369be6ecf57cc16 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Adri=C3=A1n=20Mugnolo?= <adrian@mugnolo.com>
Date: Wed, 8 Jul 2026 11:08:56 -0300
Subject: [PATCH] Linter: Allow `application/ld+json` for
 `html-allowed-script-type` rule

---
 .../docs/rules/html-allowed-script-type.md    | 21 ++++++++++++++++++-
 .../src/rules/html-allowed-script-type.ts     |  2 +-
 .../rules/html-allowed-script-type.test.ts    |  6 +++++-
 3 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/javascript/packages/linter/docs/rules/html-allowed-script-type.md b/javascript/packages/linter/docs/rules/html-allowed-script-type.md
index 13e79991e..3e3f56e9d 100644
--- a/javascript/packages/linter/docs/rules/html-allowed-script-type.md
+++ b/javascript/packages/linter/docs/rules/html-allowed-script-type.md
@@ -4,7 +4,7 @@
 
 ## Description
 
-Restricts which `type` attribute values are permitted on `<script>` tags. Only approved types are allowed: `text/javascript`. An empty or valueless `type` attribute is reported.
+Restricts which `type` attribute values are permitted on `<script>` tags. Only approved types are allowed: `text/javascript`, `module`, `importmap`, `speculationrules`, and `application/ld+json`. An empty or valueless `type` attribute is reported.
 
 ## Rationale
 
@@ -12,6 +12,8 @@ Developers frequently use `<script>` tags with non-executable type attributes (l
 
 By restricting the allowed `type` values and requiring the `type` attribute to be present, this rule helps catch typos and discourages unsafe or unintended script usage patterns.
 
+An exception is made for `application/ld+json`, which the HTML specification treats as an inert [data block](https://html.spec.whatwg.org/multipage/scripting.html#data-block): it is the standard mechanism for embedding JSON-LD structured data, and consumers such as search engines only recognize it inside a `<script>` element.
+
 ## Examples
 
 ### ✅ Good
@@ -28,6 +30,16 @@ By restricting the allowed `type` values and requiring the `type` attribute to b
 </script>
 ```
 
+```erb
+<script type="application/ld+json">
+  {
+    "@context": "https://schema.org",
+    "@type": "Organization",
+    "name": "Example"
+  }
+</script>
+```
+
 ### 🚫 Bad
 
 ```erb
@@ -42,6 +54,12 @@ By restricting the allowed `type` values and requiring the `type` attribute to b
 </script>
 ```
 
+```erb
+<script type="application/json">
+  { "name": "Example" }
+</script>
+```
+
 ```erb
 <script type="">
   console.log("Hello")
@@ -57,3 +75,4 @@ By restricting the allowed `type` values and requiring the `type` attribute to b
 ## References
 
 - [Inspiration: ERB Lint `AllowedScriptType` rule](https://github.com/Shopify/erb_lint/tree/main?tab=readme-ov-file#allowedscripttype)
+- [HTML specification: data blocks](https://html.spec.whatwg.org/multipage/scripting.html#data-block)
diff --git a/javascript/packages/linter/src/rules/html-allowed-script-type.ts b/javascript/packages/linter/src/rules/html-allowed-script-type.ts
index 1d9e7d23f..a2279c47e 100644
--- a/javascript/packages/linter/src/rules/html-allowed-script-type.ts
+++ b/javascript/packages/linter/src/rules/html-allowed-script-type.ts
@@ -8,7 +8,7 @@ import type { HTMLAttributeNode, HTMLOpenTagNode, ParseResult } from "@herb-tool
 // NOTE: Rules are not configurable for now, keep some sane defaults
 //   See https://github.com/marcoroth/herb/issues/1204
 const ALLOW_BLANK = true
-const ALLOWED_TYPES = ["text/javascript", "module", "importmap", "speculationrules"]
+const ALLOWED_TYPES = ["text/javascript", "module", "importmap", "speculationrules", "application/ld+json"]
 
 class AllowedScriptTypeVisitor extends BaseRuleVisitor {
   visitHTMLOpenTagNode(node: HTMLOpenTagNode): void {
diff --git a/javascript/packages/linter/test/rules/html-allowed-script-type.test.ts b/javascript/packages/linter/test/rules/html-allowed-script-type.test.ts
index f52396581..c3d421bd7 100644
--- a/javascript/packages/linter/test/rules/html-allowed-script-type.test.ts
+++ b/javascript/packages/linter/test/rules/html-allowed-script-type.test.ts
@@ -37,12 +37,16 @@ describe("html-allowed-script-type", () => {
     expectNoOffenses('<script type="speculationrules"></script>')
   })
 
+  test("passes when type is application/ld+json", () => {
+    expectNoOffenses('<script type="application/ld+json"></script>')
+  })
+
   test("passes for script tag with ERB in type attribute", () => {
     expectNoOffenses('<script type="<%= script_type %>"></script>')
   })
 
   test("fails when type is not allowed", () => {
-    expectError('Avoid using `text/yavascript` as the `type` attribute for the `<script>` tag. Must be one of: `text/javascript`, `module`, `importmap`, `speculationrules` or blank.')
+    expectError('Avoid using `text/yavascript` as the `type` attribute for the `<script>` tag. Must be one of: `text/javascript`, `module`, `importmap`, `speculationrules`, `application/ld+json` or blank.')
 
     assertOffenses('<script type="text/yavascript"></script>')
   })