Formatter: Opening and closing a tag in different `<% if %>` blocks

[olivier-thatch]

Input:

<% if wrap_in_dialog? %>
  <dialog>
<% end %>

<div>Stuff</div>

<% if wrap_in_dialog? %>
  </dialog>
<% end %>

Output:

<% if wrap_in_dialog? %>
  <dialog>
    <% end %>
    <div>Stuff</div>
    <% if wrap_in_dialog? %>
  </dialog>
<% end %>

Expected:

<% if wrap_in_dialog? %>
  <dialog>
<% end %>

    <div>Stuff</div>

<% if wrap_in_dialog? %>
  </dialog>
<% end %>

Playground:

https://herb-tools.dev/playground?tab=format#DwUgBAlgZmDuBOBDADgfQgO1QEwogNgPYDmA-GCAHwBQYYwuBJNoYAphthTdQxAG6UAygBcArlCjAA9LkHVe4aHCRpMOPETLda9WZuaL2nHUA

Additional context:

Kinda related to #398. This code doesn't cause any linting errors, but it is formatted incorrectly. Maybe it should actually cause a linting/parsing error? What would be good/idiomatic ERB for this?

[marcoroth]

Oh, I should have read this one first before replying in #398 😅 This one might actually be a duplicate of #84.

I'm also not 100% what the best way for this is, but I've been using this pattern:

<% content = capture do %>
  <div>Stuff</div>
<% end %>

<%= wrap_in_dialog? ? content_tag(:dialog, content) : content %>

[olivier-thatch]

Ah yeah, this is indeed a dupe, sorry about that.

Thanks for the suggestion! It does make the template a bit more opaque, but it's a good compromise 👍

[marcoroth]

No worries, I wasn't aware that this is causing a formatting issue now and that it isn't causing a linter/parser error/warning which is good to keep in mind 😅

If you have any other ideas on how to make it more readable/maintainable/idiomatic let me know. This is, and should be, a community driven project. I'm more than happy to discuss what we "should enforce" style-wise as the community-recommend way.

[marcoroth]

This should now be fixed via #795.

Fixed as in: It's not trying to format this document since it sees the conditional open and closing tags as a parse error. Since we are still tracking the issue with the conditional open/close tags in #84 I'm going to close this, thank you!