Skip to content

Parser: Herb fails on one-liner inline block in tag attributes #1410

Description

@styx

herb (0.8.10) (can't check on latest as it is a dependency for ReActionView)

          <div
            class="mt-4"
            data-employer-form-target="entityField"
            <% unless f.object.report_type == "the_type" %>hidden<% end %>
          >
            <%= f.label :employer_id %>
          </div>

running herb over code above results in ⚠️ Parse errors: 1 (33.3%)
MissingERBEndTagError: <% unless %> started here but never closed with an end tag.

if unless is reformatted as

            <% unless f.object.report_type == "the_type" %>
              hidden
            <% end %>

error is gone.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions