Add type hints to entities and service layers

[joepal1976]

Although python is a dynamically typed language, type hints have been an integrated part for some time now (see for example the PEP https://peps.python.org/pep-0484/).

While not mandatory for functionality, type hints makes life easier in code editors and it opens up for running automatic checker such as mypy.

So far MPFB is mostly without type hints, although there are infrequent and spotty coverage here and there.

The service layer (src/mpfb/services) should obviously have a thorough coverage of type hints. The entities layer (src/mpfb/entities) would also benefit, although the nodemodel (src/mpfb/entities/nodemodel) should probably be out of scope.

Covering the ui layer with type hints seems like more effort than it would be worth.

[yehorcallmedai-maker]

Hi @joepal1976 — I'd like to take a first pass at this, starting with logservice.py in the services layer. It's self-contained, the method signatures use only stdlib types (str, int, bool, Optional), and it already has docstrings — so it's a clean starting point with minimal risk of introducing import-side effects.

I'll add PEP 484-compliant annotations to Logger, LogService, and _LogService, and run any available tests before submitting.

Does this sound like the right entry point, or is there a file you'd prefer to start with?

[joepal1976]

@yehorcallmedai-maker : You are welcome to start with this. The files you suggest sounds sensible.

I haven't really done anything with this yet, apart from idly googling some of the basics. Only lesson learned from that is that given that mpfb isn't intended to run on anything older than blender 4.2, it's safe to assume that modern style (python 3.10+) type hints can be used.

I've also played around with mypy and pyright to add some kind of checking, but didn't get very far there either.

So, go ahead where you think it makes sense. I'd suggest doing a few files at a time and send a PR for those rather than aiming at covering more in one go.

[joepal1976]

@yehorcallmedai-maker : I've added some config for pyright now. I'm going to use that locally when doing the actual type checking.

I've also updated objectservice to fix the problems discovered by pyright.

[yehorcallmedai-maker]

Thanks for adding the pyright config — that's exactly the kind of signal that makes the pass more useful. I'll use it locally before submitting the next PR so the diff comes in clean.
Planning to continue with modifierservice.py next — it's small and the return types map cleanly to bpy.types.Modifier. After that I'll look at locationservice.py or jsoncall.py depending on complexity.
Happy to keep the cadence at one or two files per PR as you suggested.

[joepal1976]

@yehorcallmedai-maker thanks for putting in the effort.

I'll mainly deal with some UI bugs next, so there shouldn't be be much movement in the service layer.