From fd13fd44fb7dbc9b883cd08ec3378301836117d4 Mon Sep 17 00:00:00 2001 From: Jon Froehlich Date: Wed, 24 Jun 2026 06:24:08 -0700 Subject: [PATCH] Remove dead Banner cruft from people/news/member views (#661) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 2018 design that put banners on multiple page types (People, News, etc.) was never implemented — it only ever existed as commented-out Banner.PEOPLE / page= stubs plus now-unused Banner imports. Banners today render only on the landing page and one project page, so this code is dead. Removing it alongside closing #661 as obsolete. Co-Authored-By: Claude Opus 4.8 (1M context) --- website/views/member.py | 7 +------ website/views/news_listing.py | 2 +- website/views/people.py | 2 +- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/website/views/member.py b/website/views/member.py index cb8a0e58..c4021d23 100644 --- a/website/views/member.py +++ b/website/views/member.py @@ -87,12 +87,8 @@ def member(request, member_name=None, member_id=None): raise Http404("No person matches the given query.") news_items_num = 5 # Defines the number of news items that will be selected - # all_banners = Banner.objects.filter(page=Banner.PEOPLE) - # displayed_banners = ml_utils.choose_banners(all_banners) - - - # Returns QuerySet of News objects that mention the specified person. + # Returns QuerySet of News objects that mention the specified person. # The order_by('-date') part sorts the QuerySet by date in descending order # (so the most recent news comes first), and [:4] limits the QuerySet to # the first 4 objects. @@ -146,7 +142,6 @@ def member(request, member_name=None, member_id=None): 'mobile_page_sizes': ARTIFACT_MOBILE_PAGE_SIZES, 'project_roles': project_roles, 'position' : latest_position, - # 'banners': displayed_banners, 'left_align_headers': left_align_headers, 'debug': settings.DEBUG, 'navbar_white': True, diff --git a/website/views/news_listing.py b/website/views/news_listing.py index 858470f9..36bd5fea 100644 --- a/website/views/news_listing.py +++ b/website/views/news_listing.py @@ -1,5 +1,5 @@ from django.conf import settings # for access to settings variables, see https://docs.djangoproject.com/en/4.0/topics/settings/#using-settings-in-python-code -from website.models import Banner, News +from website.models import News import datetime import website.utils.ml_utils as ml_utils from django.shortcuts import render diff --git a/website/views/people.py b/website/views/people.py index e6bbc793..5026c8d0 100644 --- a/website/views/people.py +++ b/website/views/people.py @@ -1,5 +1,5 @@ from django.conf import settings # for access to settings variables, see https://docs.djangoproject.com/en/4.0/topics/settings/#using-settings-in-python-code -from website.models import Banner, Position, Person, Publication +from website.models import Position, Person, Publication from website.models.position import Role from website.models.publication import PubType import website.utils.ml_utils as ml_utils