[PB-012] Audit, Compliance, System Integrity

[ma7moudalysalem]

Owner: @ma7moudalysalem
Spec: .specify/specs/PB-012-audit-compliance/
SRS: US-139..US-142

[Auditable] MediatR behavior + 30-day delayed delete Hangfire job.

[ma7moudalysalem]

Status — foundational work done, open for polish + team sign-off

This comment summarises everything shipped for PB-012 against the spec-folder tasks. Issue stays open until the other teammates verify their touch-points and we sign off QA.

Backend (8/8 done)

Task	Commit	Notes
T-001 AuditLog + UserDataRequest entities	16d9046	landed with the initial 40-entity migration
T-002 IAuditService + AuditBehavior pipeline	e5b20c6	MediatR behavior, reflection-based TargetId resolution, swallows audit-write failures
T-003 [Auditable] on admin commands	2c95359, d5c3da5, 0fbade7	every admin mutation audited automatically
T-004 RequestDataExportCommand + DataExportJob	1980978	single in-flight per user; Hangfire sweep packs JSON + signed URL (14d TTL)
T-005 RequestDataDeleteCommand + 30-day job + cancel	1980978	CancelDataDeleteCommand reverses before cooling period ends
T-006 IntegrityCheckJob	dc9f94d	daily sweep for orphan payments / overdue bookings / stuck webhooks
T-007 Admin GetAuditLogQuery	dc9f94d	pagination (≤ 200/page) + 6 filters, joined to Users for actor email
T-008 Unit tests	1de65ed	4 tests on AuditBehavior — attribute presence, fallback, exception tolerance

Frontend (3/3 done)

Task	Commit	Notes
T-009 Student DataPrivacy.tsx	c39d53d	export + delete cards, cooling-period countdown, request history
T-010 Admin AuditLog.tsx viewer	aa790dd	search + action/target/actor/date filters, color-coded badges, 50/page
T-011 Arabic copy	c39d53d, aa790dd	full AR namespaces for privacy.json + admin.audit.*

Tests

• 4 unit tests on the audit behavior (part of the 52 total green).
• E2E route-guard smoke tests land in client/src/test/e2e/admin.spec.ts.

Files of interest

• server/src/ScholarPath.Application/Common/Behaviors/AuditBehavior.cs
• server/src/ScholarPath.Infrastructure/Services/AuditService.cs
• server/src/ScholarPath.Infrastructure/Jobs/DataExportJob.cs + DataDeleteJob.cs
• server/src/ScholarPath.Application/Audit/Queries/GetAuditLog/
• client/src/pages/profile/DataPrivacy.tsx
• client/src/pages/admin/AuditLogViewer.tsx

Done-criteria check

• ✅ Audit pipeline non-invasive (single attribute opt-in, never fails the command)
• ✅ Export + delete flows end-to-end in dev with MailHog
• ✅ 30-day delete cooling period w/ cancel option