From 699abf5b8b13ca39803f038f1bf879144e4620ac Mon Sep 17 00:00:00 2001 From: hirosassa Date: Wed, 13 May 2026 15:07:23 +0900 Subject: [PATCH 1/3] fix ExplicitBoolParameter.__init__ to use super() instead of direct Parameter.__init__ call --- gokart/parameter.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gokart/parameter.py b/gokart/parameter.py index 9866e44b..267f1b8b 100644 --- a/gokart/parameter.py +++ b/gokart/parameter.py @@ -114,7 +114,7 @@ def _warn_on_wrong_param_type(self, param_name, param_value): class ExplicitBoolParameter(luigi.BoolParameter): def __init__(self, *args, **kwargs): - luigi.Parameter.__init__(self, *args, **kwargs) + super(luigi.BoolParameter, self).__init__(*args, **kwargs) def _parser_kwargs(self, *args, **kwargs): # type: ignore return luigi.Parameter._parser_kwargs(*args, *kwargs) From ff5ec4ba300893b3a82cd3e97b7087e5ef488bdb Mon Sep 17 00:00:00 2001 From: hirosassa Date: Wed, 13 May 2026 15:09:08 +0900 Subject: [PATCH 2/3] add type annotation --- gokart/task.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gokart/task.py b/gokart/task.py index 09350ef4..ba9db044 100644 --- a/gokart/task.py +++ b/gokart/task.py @@ -395,7 +395,7 @@ def _to_str_params(task): return task.to_str_params(only_significant=True) - dependencies = [_to_str_params(task) for task in flatten(self.requires())] + dependencies: list[Any] = [_to_str_params(task) for task in flatten(self.requires())] dependencies = [d for d in dependencies if d is not None] dependencies.append(self.to_str_params(only_significant=True)) dependencies.append(self.__class__.__name__) From 1527ebe912cc6bbf16e3444c232d67dd3abe9dbc Mon Sep 17 00:00:00 2001 From: hirosassa Date: Wed, 13 May 2026 15:14:32 +0900 Subject: [PATCH 3/3] cast param_value to TaskOnKart --- gokart/task.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gokart/task.py b/gokart/task.py index ba9db044..1d1556d4 100644 --- a/gokart/task.py +++ b/gokart/task.py @@ -438,7 +438,7 @@ def get_info(self, only_significant=False): for param_name, param_value in self.param_kwargs.items(): if (not only_significant) or params[param_name].significant: if isinstance(params[param_name], gokart.TaskInstanceParameter): - params_str[param_name] = type(param_value).__name__ + '-' + param_value.make_unique_id() + params_str[param_name] = type(param_value).__name__ + '-' + cast(TaskOnKart[Any], param_value).make_unique_id() else: params_str[param_name] = params[param_name].serialize(param_value) return params_str