From f0f801c4ce4e420c04b99948761bc45a26f9224c Mon Sep 17 00:00:00 2001 From: hirosassa Date: Wed, 13 May 2026 12:13:58 +0900 Subject: [PATCH 1/2] fix type issues in config_params.py and run.py --- gokart/config_params.py | 6 +++--- gokart/run.py | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/gokart/config_params.py b/gokart/config_params.py index e21b4541..ad0a2163 100644 --- a/gokart/config_params.py +++ b/gokart/config_params.py @@ -1,6 +1,6 @@ from __future__ import annotations -from typing import Any +from typing import Any, cast import luigi @@ -27,10 +27,10 @@ class Wrapped(task_class): # type: ignore @classmethod def get_param_values(cls, params, args, kwargs): for param_key, param_value in self._config_class().param_kwargs.items(): - task_param_key = self._parameter_alias.get(param_key, param_key) + task_param_key = self._parameter_alias.get(param_key) or param_key if hasattr(cls, task_param_key) and task_param_key not in kwargs: kwargs[task_param_key] = param_value return super().get_param_values(params, args, kwargs) - return Wrapped + return cast(type[gokart.TaskOnKart[Any]], Wrapped) diff --git a/gokart/run.py b/gokart/run.py index 91ec72bb..27cf2340 100644 --- a/gokart/run.py +++ b/gokart/run.py @@ -4,7 +4,7 @@ import os import sys from logging import getLogger -from typing import Any +from typing import Any, cast import luigi import luigi.cmdline @@ -102,7 +102,7 @@ def _run_with_retcodes(argv): sys.exit(retcodes.already_running) except Exception: env_params = luigi.interface.core() - luigi.setup_logging.InterfaceLogging.setup(env_params) + luigi.setup_logging.InterfaceLogging.setup(cast(Any, env_params)) retcode_logger.exception('Uncaught exception in luigi') sys.exit(retcodes.unhandled_exception) @@ -142,7 +142,7 @@ def run(cmdline_args=None, set_retcode=True): _try_tree_info(cmdline_args) _try_to_delete_unnecessary_output_file(cmdline_args) - gokart.testing.try_to_run_test_for_empty_data_frame(cmdline_args) + gokart.testing.try_to_run_test_for_empty_data_frame(cmdline_args) # pyright: ignore[reportAttributeAccessIssue] slack_api = _try_get_slack_api(cmdline_args) event_aggregator = gokart.slack.EventAggregator() From df762bc50ab20b1d69e626f299ccc6af160b2576 Mon Sep 17 00:00:00 2001 From: hirosassa Date: Fri, 15 May 2026 09:22:05 +0900 Subject: [PATCH 2/2] review suggestion: fix back unnecessary change --- gokart/config_params.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gokart/config_params.py b/gokart/config_params.py index ad0a2163..a53cf20b 100644 --- a/gokart/config_params.py +++ b/gokart/config_params.py @@ -27,7 +27,7 @@ class Wrapped(task_class): # type: ignore @classmethod def get_param_values(cls, params, args, kwargs): for param_key, param_value in self._config_class().param_kwargs.items(): - task_param_key = self._parameter_alias.get(param_key) or param_key + task_param_key = self._parameter_alias.get(param_key, param_key) if hasattr(cls, task_param_key) and task_param_key not in kwargs: kwargs[task_param_key] = param_value