From 013a1d46bc08aee959ec47fbd39138aa5aa5b6e4 Mon Sep 17 00:00:00 2001 From: Qifeng Tan Date: Thu, 19 Sep 2019 22:22:29 -0700 Subject: [PATCH 1/3] node v12 fix --- package.json | 8 ++++---- src/binding.cc | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index 513430d..1c371c7 100644 --- a/package.json +++ b/package.json @@ -30,9 +30,9 @@ "test": "mocha --gc-global --expose-gc --reporter spec --use_strict" }, "dependencies": { - "bindings": "1", - "debug": "4", - "nan": "2" + "bindings": "^1.5.0", + "debug": "*", + "nan": "^2.13.2" }, "devDependencies": { "dox": "0.9.0", @@ -40,6 +40,6 @@ "jade": "1", "marked": "0.6.2", "mocha": "*", - "weak": "github:lxe/node-weak#node-12" + "weak": "file:../weak" } } diff --git a/src/binding.cc b/src/binding.cc index 35d62cf..8e35499 100644 --- a/src/binding.cc +++ b/src/binding.cc @@ -219,7 +219,7 @@ NAN_METHOD(WriteObject) { Nan::Persistent* pptr = reinterpret_cast*>(ptr); Local val = info[2].As(); - bool persistent = info[3]->BooleanValue(v8::Isolate::GetCurrent()->GetCurrentContext()).ToChecked(); + bool persistent = info[3]->BooleanValue(v8::Isolate::GetCurrent()); if (persistent) { (*pptr).Reset(val); } else { From c4b1ea18ee299395722e1e337b61fa1bb880dc6b Mon Sep 17 00:00:00 2001 From: Qifeng Tan Date: Fri, 20 Sep 2019 21:55:42 -0700 Subject: [PATCH 2/3] remove dev --- package.json | 8 -------- 1 file changed, 8 deletions(-) diff --git a/package.json b/package.json index 1c371c7..a368ca8 100644 --- a/package.json +++ b/package.json @@ -33,13 +33,5 @@ "bindings": "^1.5.0", "debug": "*", "nan": "^2.13.2" - }, - "devDependencies": { - "dox": "0.9.0", - "highlight.js": "9", - "jade": "1", - "marked": "0.6.2", - "mocha": "*", - "weak": "file:../weak" } } From 9e4e038adecef674f42e80c4df38fe9f9c042b67 Mon Sep 17 00:00:00 2001 From: fishg Date: Tue, 5 Nov 2019 09:52:37 +0800 Subject: [PATCH 3/3] =?UTF-8?q?=E6=8F=90=E9=AB=98=E7=89=88=E6=9C=AC?= =?UTF-8?q?=E5=8F=B7=EF=BC=8C=E5=8C=BA=E5=88=AB=E4=BA=8E=E5=8E=9F=E5=A7=8B?= =?UTF-8?q?=E7=89=88=E6=9C=AC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index a368ca8..e1a35ce 100644 --- a/package.json +++ b/package.json @@ -17,7 +17,7 @@ "byte", "64" ], - "version": "2.0.0", + "version": "2.0.1", "license": "MIT", "author": "Nathan Rajlich (http://tootallnate.net)", "repository": {