Skip to content

regression in lit install #365

@Bilal2453

Description

@Bilal2453

As of #333 a regression that breaks native binary installs was introduced, due to the used replacement luv.os_uname().machine, which is NOT equivalent to ffi.arch.

Meaning, packages that used to have this in its package.lua:

  files = {
    "$OS-$ARCH/*",
    "**.lua",
  }

and had a folder with the name Windows-x64 are now broken.

luv.os_uname().machine --> x86_64.
vs
ffi.arch --> x64.

Lit now expects the folder to be called Windows-x86_64 which is a breaking change.

Acceptable $ARCH values are one of the following values, and only one of them: x86, x64, arm, arm64be, arm64, ppc64le, ppc64, ppc, mips32r6el, mipsel, mips64r6el, mips64el, mips32r6, mips, mips64r6, mips64,
I think it is easier to just reintroduce the ffi API.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions