From ba337ee4d64b0a73e29e7b0809e7c632ed5beb7c Mon Sep 17 00:00:00 2001 From: Taksh Date: Wed, 8 Apr 2026 08:52:31 +0530 Subject: [PATCH] Fix moderation filter checking wrong model in arena side-by-side views In both gradio_block_arena_anony.py and gradio_block_arena_vision_named.py, `all_conv_text_right` was reading from `states[0]` instead of `states[1]`, meaning the right-side model's conversation was never checked by the moderation filter. This was already fixed in gradio_block_arena_named.py (commit 34eca62) but missed in these two files. Fixes #3794 Co-Authored-By: Claude Opus 4.6 (1M context) --- fastchat/serve/gradio_block_arena_anony.py | 2 +- fastchat/serve/gradio_block_arena_vision_named.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fastchat/serve/gradio_block_arena_anony.py b/fastchat/serve/gradio_block_arena_anony.py index 625c69c44..90048ead2 100644 --- a/fastchat/serve/gradio_block_arena_anony.py +++ b/fastchat/serve/gradio_block_arena_anony.py @@ -307,7 +307,7 @@ def add_text( model_list = [states[i].model_name for i in range(num_sides)] # turn on moderation in battle mode all_conv_text_left = states[0].conv.get_prompt() - all_conv_text_right = states[0].conv.get_prompt() + all_conv_text_right = states[1].conv.get_prompt() all_conv_text = ( all_conv_text_left[-1000:] + all_conv_text_right[-1000:] + "\nuser: " + text ) diff --git a/fastchat/serve/gradio_block_arena_vision_named.py b/fastchat/serve/gradio_block_arena_vision_named.py index 7c653acf3..334686773 100644 --- a/fastchat/serve/gradio_block_arena_vision_named.py +++ b/fastchat/serve/gradio_block_arena_vision_named.py @@ -242,7 +242,7 @@ def add_text( model_list = [states[i].model_name for i in range(num_sides)] all_conv_text_left = states[0].conv.get_prompt() - all_conv_text_right = states[0].conv.get_prompt() + all_conv_text_right = states[1].conv.get_prompt() all_conv_text = ( all_conv_text_left[-1000:] + all_conv_text_right[-1000:] + "\nuser: " + text )