Incorrect colours after typescript migration

[Canowyrms]

Hello,

I've been using Noctis Bordo in VS Code for some time now - I really like it! I sometimes use JetBrains IDEs, and recently, the only plugin (that I'm aware of) that offered Noctis Bordo has become unavailable for download and no longer works with newer IDE versions. So, I was going through this repo in hopes of potentially porting Noctis and its "flavours" to JetBrains IDEs.

While going through this repo, I noticed the Bordo colours in themes/bordo.json weren't matching what I was seeing in VS Code with this theme active. After some troubleshooting, I noticed there was a commit made after the latest release of the Noctis plugin on VS Code Marketplace - the TypeScript migration commit (144e65c). I compared this file to its previous commit (25a8a5e). The colours in themes/bordo.json as it exists in the repo right now are far off from what it appears they should be.

To confirm, I took the colors object of themes/bordo.json from the most recent commit and from the previous commit, sorted the keys alphabetically, and, for the object from the previous commit, filtered out any properties that don't exist in the object from the most recent commit (just to keep it concise for the sake of demonstrating).

Most recent commit:

{
	"activityBar.background": "#052529",
	"activityBar.border": "#0f1415",
	"activityBar.foreground": "#169fb1",
	"button.background": "#099",
	"button.foreground": "#ebfdff",
	"dropdown.background": "#073940",
	"dropdown.border": "#073940",
	"dropdown.foreground": "#87a7ab",
	"editor.background": "#052529",
	"editor.foreground": "#cbbec2",
	"editor.lineHighlightBackground": "#083d44ee",
	"editor.selectionBackground": "#169fb144",
	"editorCursor.foreground": "#85efff",
	"editorLineNumber.activeForeground": "#169fb1",
	"editorLineNumber.foreground": "#4e6b6e",
	"editorWidget.background": "#073940",
	"editorWidget.border": "#0f1415",
	"input.background": "#052529",
	"input.border": "#073940",
	"input.foreground": "#CDD3DE",
	"list.activeSelectionBackground": "#0e6671",
	"list.activeSelectionForeground": "#ebfdff",
	"list.hoverBackground": "#0b515b",
	"list.hoverForeground": "#ebfdff",
	"panel.background": "#03191b",
	"panel.border": "#0e6671",
	"selection.background": "#107684",
	"sideBar.background": "#041d20",
	"sideBar.border": "#0f1415",
	"sideBar.foreground": "#a5b5b5",
	"statusBar.background": "#041d20",
	"statusBar.border": "#0f1415",
	"statusBar.foreground": "#169fb1",
	"tab.activeBackground": "#052529",
	"tab.activeForeground": "#40d4e7",
	"tab.border": "#0f1415",
	"tab.inactiveBackground": "#062e32",
	"tab.inactiveForeground": "#87a7ab",
	"terminal.background": "#03191b",
	"terminal.foreground": "#cbbec2"
}

Previous commit:

{
	"activityBar.background": "#322a2d",
	"activityBar.border": "#1f191b",
	"activityBar.foreground": "#997582",
	"button.background": "#007f99",
	"button.foreground": "#edebff",
	"dropdown.background": "#413036",
	"dropdown.border": "#413036",
	"dropdown.foreground": "#bb778f",
	"editor.background": "#322a2d",
	"editor.foreground": "#cbbec2",
	"editor.lineHighlightBackground": "#453138aa",
	"editor.selectionBackground": "#99758255",
	"editorCursor.foreground": "#ffb3cd",
	"editorLineNumber.activeForeground": "#bb778f",
	"editorLineNumber.foreground": "#715b63",
	"editorWidget.background": "#413036",
	"editorWidget.border": "#1f191b",
	"input.background": "#272022",
	"input.border": "#412a32",
	"input.foreground": "#ddd5d7",
	"list.activeSelectionBackground": "#5c2e3e99",
	"list.activeSelectionForeground": "#edebff",
	"list.hoverBackground": "#533641",
	"list.hoverForeground": "#edebff",
	"panel.background": "#272022",
	"panel.border": "#997582",
	"selection.background": "#88445cbb",
	"sideBar.background": "#2c2528",
	"sideBar.border": "#1f191b",
	"sideBar.foreground": "#bbaab0",
	"statusBar.background": "#322a2d",
	"statusBar.border": "#1f191b",
	"statusBar.foreground": "#997582",
	"tab.activeBackground": "#322a2d",
	"tab.activeForeground": "#f18eb0",
	"tab.border": "#1f191b",
	"tab.inactiveBackground": "#413036",
	"tab.inactiveForeground": "#bbaab0",
	"terminal.background": "#272022",
	"terminal.foreground": "#cbbec2"
}

Diff those objects and you'll see the colours in the most recent commit are far off from what they were in the previous commit (previous commit I think is what the colours are supposed to be):

I haven't checked the other themes to determine if colours were incorrectly ported over yet. I'm curious what your thoughts are on this.

[liviuschera]

Yeah, you're totally right about those Bordo colors being off. The current themes/bordo.json is definitely using the wrong colors,looks like they got mixed up with another theme during that TypeScript migration.

For now, I just reverted back to the previous commit so we have the right colors again until I can find time to properly sort out what went wrong with the migration.

Thanks for spotting this and doing that detailed comparison, super helpful for figuring out exactly what got messed up!