From 717c2db71c5aa4bacfb284ba8e8cd51e697a6fdc Mon Sep 17 00:00:00 2001
From: Martin Belanger <martin.belanger@dell.com>
Date: Mon, 22 Jun 2026 13:55:09 -0400
Subject: [PATCH] libnvme: test that registry attribute values round-trip
 verbatim

Attribute values are free-form -- only device and attribute names are
validated, never the value. Add a test that stores a value containing
spaces, double quotes, an apostrophe and punctuation, then confirms it
reads back byte-for-byte, so this guarantee cannot regress through
accidental escaping or sanitization of the value.

Signed-off-by: Martin Belanger <martin.belanger@dell.com>
---
 libnvme/test/registry.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/libnvme/test/registry.c b/libnvme/test/registry.c
index 4d47a0ad44..0b610d52e2 100644
--- a/libnvme/test/registry.c
+++ b/libnvme/test/registry.c
@@ -143,6 +143,41 @@ static bool test_update_and_retrieve(struct libnvme_global_ctx *ctx)
 	return pass;
 }
 
+static bool test_special_chars(struct libnvme_global_ctx *ctx)
+{
+	/*
+	 * Attribute values are free-form text -- only device and attribute
+	 * names are validated, never the value.  Verify a value with spaces,
+	 * double quotes, an apostrophe and punctuation round-trips
+	 * byte-for-byte.
+	 */
+	const char *special = "ACME Corp \"prod\" team's box !@#%";
+	char *value = NULL;
+	bool pass = true;
+	int ret;
+
+	printf("test_special_chars:\n");
+
+	ret = libnvmf_registry_update(ctx, "nvme5", "owner", special);
+	if (ret) {
+		printf(" - update returned %d [FAIL]\n", ret);
+		return false;
+	}
+
+	ret = libnvmf_registry_retrieve(ctx, "nvme5", "owner", &value);
+	if (ret || !value || strcmp(value, special) != 0) {
+		printf(" - expected '%s', got '%s' ret=%d [FAIL]\n",
+		       special, value ? value : "(null)", ret);
+		pass = false;
+	} else {
+		printf(" - round-trip '%s' [PASS]\n", value);
+	}
+
+	free(value);
+	libnvmf_registry_delete(ctx, "nvme5");
+	return pass;
+}
+
 static bool test_delete(struct libnvme_global_ctx *ctx)
 {
 	char *value = NULL;
@@ -448,6 +483,7 @@ int main(int argc, char *argv[])
 
 	pass &= test_create(ctx);
 	pass &= test_update_and_retrieve(ctx);
+	pass &= test_special_chars(ctx);
 	pass &= test_delete(ctx);
 	pass &= test_retrieve_missing(ctx);
 	pass &= test_device_for_each(ctx);