Using RMT with Mercurial and Simple version generation is broken when Mercurial version > 3

[krtek4]

It seems that beginning with Mercurial version 3.0, it is now impossible to use purely numeric tag name :

$ hg tag 1
abort: cannot use an integer as a name
$ hg --version
Mercurial Distributed SCM (version 3.1)

But it is working on version 2.2 :

$ hg tag 1
$ hg --version
Mercurial Distributed SCM (version 2.2.2)

I don't know if there is a lot of Mercurial users out there using RMT, but this issue should be addressed. I see two possible solutions :

1. Forbid the use the Simple version generation when Mercurial is used
2. Add some kind of prefix to simple tags, like 'v\d+' instead of the current '\d+'

The problem with 2) is that it is can be a big BC break depending on the implementation.

FYI : the test suite is currently failing when ran with the "faulty" Mercurial version.

[jeanmonod]

Hi @krtek4,
Thanks for this detailed bug report. Personally I will go for solution 2) but without doing it automatically. What about:

1. Adding a warning about that issue in the documentation, recommending to use the existing RMT prefix mechanism.
2. Better catching the exception, and forwarding the user to the documentation

So like this the BC break stay in the mercurial side. What do you think of this approach?

[jeanmonod]

@krtek4 up!

[krtek4]

Stop resurrecting old bugs, it's not Zombie Jesus Day !

Problem is, the solution you propose does not really fix the tests... I'll try to have a look :)

[jeanmonod]

Was not able to release yesterday ;) I have Mercurial 3.2 on my Mac and no easy way to downgrade...