You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, if you call ->log('critical', 'some critical message', ['some' => 'context'); this will make a call to ->info('critical', 'some critical message');. Therefore the message being logged is critical and the context is a string instead of an array.
In case I don't oversee something, this is bug, if not dangerous if anybody is using that.
If monolog doesn't support log then the Adaptor should rather make a switch on the level and call the appropriate method.
log implementation:
https://github.com/liip/DataAggregator/blob/master/src/Liip/DataAggregator/Adaptor/Logger/MonologAdaptor.php#L155
info implementation:
https://github.com/liip/DataAggregator/blob/master/src/Liip/DataAggregator/Adaptor/Logger/MonologAdaptor.php#L125
So, if you call
->log('critical', 'some critical message', ['some' => 'context');this will make a call to->info('critical', 'some critical message');. Therefore the message being logged iscriticaland the context is a string instead of an array.In case I don't oversee something, this is bug, if not dangerous if anybody is using that.
If monolog doesn't support
logthen the Adaptor should rather make a switch on the level and call the appropriate method.