code break with Python 3.7

[henriklynggaard]

Trying to test my code with multiple versions of python. Python 3.5 and 3.6 works fine, but on 3.7 it breaks

=================================== ERRORS ====================================
__________________ ERROR collecting tests/test_config_load.py __________________
tests/test_config_load.py:1: in
from undercommit.config.config_loader import ConfigurationLoader
undercommit/config/config_loader.py:5: in
from undercommit.config.config import Configuration
undercommit/config/config.py:4: in
from class_registry.entry_points import EntryPointClassRegistry
.eggs/class_registry-2.1.2-py3.7.egg/class_registry/init.py:5: in
from .registry import *
.eggs/class_registry-2.1.2-py3.7.egg/class_registry/registry.py:33: in
class BaseRegistry(with_metaclass(ABCMeta, Mapping)):
.eggs/six-1.12.0-py3.7.egg/six.py:827: in new
return meta(name, bases, d)
/usr/local/lib/python3.7/abc.py:126: in new
cls = super().new(mcls, name, bases, namespace, **kwargs)
E TypeError: type() doesn't support MRO entry resolution; use types.new_class()
________________ ERROR collecting tests/test_config_matching.py ________________
tests/test_config_matching.py:1: in
from undercommit.config.config import Configuration
undercommit/config/config.py:4: in
from class_registry.entry_points import EntryPointClassRegistry
.eggs/class_registry-2.1.2-py3.7.egg/class_registry/init.py:5: in
from .registry import *
.eggs/class_registry-2.1.2-py3.7.egg/class_registry/registry.py:33: in
class BaseRegistry(with_metaclass(ABCMeta, Mapping)):
.eggs/six-1.12.0-py3.7.egg/six.py:827: in new
return meta(name, bases, d)
/usr/local/lib/python3.7/abc.py:126: in new
cls = super().new(mcls, name, bases, namespace, **kwargs)
E TypeError: type() doesn't support MRO entry resolution; use types.new_class()
_________________ ERROR collecting tests/test_config_merger.py _________________
tests/test_config_merger.py:1: in
from undercommit.config.config import Configuration
undercommit/config/config.py:4: in
from class_registry.entry_points import EntryPointClassRegistry
.eggs/class_registry-2.1.2-py3.7.egg/class_registry/init.py:5: in
from .registry import *
.eggs/class_registry-2.1.2-py3.7.egg/class_registry/registry.py:33: in
class BaseRegistry(with_metaclass(ABCMeta, Mapping)):
.eggs/six-1.12.0-py3.7.egg/six.py:827: in new
return meta(name, bases, d)
/usr/local/lib/python3.7/abc.py:126: in new
cls = super().new(mcls, name, bases, namespace, **kwargs)
E TypeError: type() doesn't support MRO entry resolution; use types.new_class()
!!!!!!!!!!!!!!!!!!! Interrupted: 3 errors during collection !!!!!!!!!!!!!!!!!!!!
=========================== 3 error in 0.41 seconds ============================

[todofixthis]

Hey @henriklynggaard thanks for reporting this! I'll have a look 😺

[NotANormalNerd]

@todofixthis Thanks for the fix. I just encountered the same problem.
Would you mind merging this and/or pushing it to pypi?

[todofixthis]

Hey @NotANormalNerd I no longer work at LenndoEFL, so unfortunately I no longer have merge perms for this repo. I've reached out to the team to see how they'd like to proceed.

[saltysealion]

@todofixthis I'm having this same issue is there something I need to do to get this fix merged?