extract.broom assumes glance() will return a df with more than 1 column

[MatthieuStigler]

Hi

extract.broom() uses out <- broom::glance(model)[1, ]. Using [1, ] implicitly assumes that the result of broom::glance(model) has at least two columns (if only one, will not be a df anymore).

Could you use instead out <- broom::glance(model)[1, , drop=FALSE] ?

Thanks!

PS: happy to send a pull request if easier for you!?

[leifeld]

Thanks. Happy to accept a PR, but the please increment the minor version number and add a testthat unit test to tests/testthat/test-extract.R. Otherwise I'll get to it at some point when I'm less busy.

[MatthieuStigler]

ok, I've made a pull request. I didn't add a testthat unit test though, as the case in hand was quite specific?

[leifeld]

Thanks and no problem, I'll get to it soon.

[MatthieuStigler]

Hallo @leifeld

did you get a chance to look at this PR? It's a one line change (well, one character, see 107d640), so I am quite confident it is correct:-). Thanks!!