Rename StreamProxy helper to LiteRtLmBridge#8
Merged
Conversation
936887d to
ebb2509
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
native/bridge/litert_lm_bridge.cand keep the exportedstream_proxy_*symbols unchanged for downstream ABI compatibility.native/bridge/BUILD.bazelpackage that defines the shared LiteRT-LM runtime targets with embedded bridge symbols.tools/build_upstream_runtime.pybuild//bridge:*through Bazel--package_path=<repo native dir>:<upstream source>, so source-built runtimes no longer copy files into upstream or edit upstreamc/BUILD,WORKSPACE, or patch files.docs/current_upstream.mdto the latest upstreamv0.13.1metadata reported by the repo tooling.Validation
python3 tools/build_upstream_runtime.py --upstream-tag local --platform macos --arch arm64 --source-root /opt/UnitySrc/personal/llama/LiteRT-LM-text-lora-resource-manager --jobs=4//bridge:libLiteRtLm.dylibthrough--package_path.stream_proxy_*bridge symbols.bin/macos/arm64/libLiteRtLm.dylib.python3 tools/build_upstream_runtime.py --upstream-tag local --platform macos --arch x64 --source-root /opt/UnitySrc/personal/llama/LiteRT-LM-text-lora-resource-manager --jobs=4//bridge:libLiteRtLm.dylibthrough--package_path.stream_proxy_*bridge symbols.bin/macos/x64/libLiteRtLm.dylib.ANDROID_NDK_HOME="$HOME/Library/Android/sdk/ndk/28.2.13676358" python3 tools/build_upstream_runtime.py --upstream-tag local --platform android --arch arm64 --source-root /opt/UnitySrc/personal/llama/LiteRT-LM-text-lora-resource-manager --jobs=4//bridge:libLiteRtLm.sothrough--package_path.stream_proxy_*bridge symbols.libLiteRtLm.so,libGemmaModelConstraintProvider.so, andlibLiteRt.so.ANDROID_NDK_HOME="$HOME/Library/Android/sdk/ndk/28.2.13676358" python3 tools/build_upstream_runtime.py --upstream-tag local --platform android --arch x64 --source-root /opt/UnitySrc/personal/llama/LiteRT-LM-text-lora-resource-manager --jobs=4//bridge:libLiteRtLm.sothrough--package_path.stream_proxy_*bridge symbols.libLiteRtLm.so,libGemmaModelConstraintProvider.so, andlibLiteRt.so.docker run --platform linux/arm64 ... python3 tools/build_upstream_runtime.py --upstream-tag local --platform linux --arch arm64 --source-root /work/LiteRT-LM --jobs=4 && python3 tools/validate_runtime_dependencies.py//bridge:libLiteRtLm.sothrough--package_pathfrom a container-local copy of both repos.stream_proxy_*bridge symbols.libLiteRtLm.so,libGemmaModelConstraintProvider.so, andlibLiteRt.soin the container copy.linux/amd64emulation:docker run --platform linux/amd64 ... python3 tools/build_upstream_runtime.py --upstream-tag local --platform linux --arch x64 --source-root /work/LiteRT-LM --jobs=4 && python3 tools/validate_runtime_dependencies.py//bridge:libLiteRtLm.sothrough--package_pathfrom a container-local copy of both repos.stream_proxy_*bridge symbols.libLiteRtLm.so,libGemmaModelConstraintProvider.so, andlibLiteRt.soin the container copy.llamadartmacOS arm64 consumer smoke using the locally staged PR runtime:LLAMADART_LITERT_LM_LIB_DIR=/opt/UnitySrc/personal/llama/litert-lm-native/bin/macos/arm64 dart run tool/litert_lm_engine_smoke.dart /opt/UnitySrc/personal/llama/LiteRT-LM-text-lora-resource-manager/runtime/testdata/test_lm.litertlm cpu 'What is 2+2? Answer only with the number.' 4 1024libLiteRtLm.dylib, initialized the LiteRT-LM CPU backend, loaded a.litertlmmodel fixture, tokenized/detokenized, and streamed 4 generated tokens throughllamadart.python3 tools/validate_runtime_dependencies.pypassed in the host checkout for the locally staged Android ELF libraries.python3 -m py_compile tools/runtime_dependency_utils.py tools/fetch_upstream.py tools/build_upstream_runtime.py tools/package_release.py tools/validate_artifacts.py tools/package_upstream_prebuilts.py tools/package_official_release_assets.py tools/package_ios_runtime.py tools/package_apple_xcframeworks.py tools/validate_runtime_artifacts.py tools/validate_runtime_dependencies.py tools/validate_release_manifest.pycc -std=c11 -Wall -Wextra -fsyntax-only native/bridge/litert_lm_bridge.cnode web/src/index.js --self-testpython3 tools/package_release.py --upstream-tag v0.12.0 && python3 tools/validate_artifacts.pycompleted with the local artifact cache; generated metadata was restored because artifact-cache churn is not part of this PR.v0.13.1in a throwaway repo copy:python3 tools/package_upstream_prebuilts.py --upstream-tag v0.13.1 --cleanrg "version https://git-lfs.github.com/spec/v1" bin -Sfound 0 Git LFS pointer files.python3 tools/fetch_upstream.py --latest --metadata-onlyresolved upstreamv0.13.1and was used to refreshdocs/current_upstream.md.git diff --checkNot run:
python3 tools/validate_runtime_artifacts.py --upstream-tag v0.13.1currently fails locally because the Linux Docker artifacts were intentionally isolated from the host checkout, the Windows runtime is absent, anddist/official/v0.13.1/CLiteRTLM.xcframework.zipis not staged locally.CLiteRTLM.xcframeworkassets.