Add LiteRT-LM LoRA C API support#7
Open
leehack wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
litert_lm_session_config_set_lora_fileandlitert_lm_session_config_set_audio_lora_fileWhy
LiteRT-LM v0.13.1 has internal LoRA manager/session-config support, but the public C wrapper and text executor path do not expose enough behavior for Dart FFI clients. This enables the native runtime bundle needed by
llamadartto support one LiteRT-LM LoRA adapter at scale 1.0.Companion llamadart PR: leehack/llamadart#206
Validation
python3 -m py_compile tools/build_upstream_runtime.pypython3 tools/build_upstream_runtime.py --upstream-tag v0.13.1 --platform macos --arch arm64 --jobs 8nm -gU bin/macos/arm64/libLiteRtLm.dylib | rg 'litert_lm_session_config_set_(audio_)?lora_file|litert_lm_conversation_create'git diff --checkRuntime smoke used by companion PR
With this locally built macOS runtime,
llamadartgenerated successfully through bothModelParams.lorasandengine.setLora(...)using:/private/tmp/litert-lm-v0.13.1-src/runtime/testdata/test_lm.litertlm/private/tmp/litert-lm-v0.13.1-src/runtime/testdata/test_lora_rank32_f16_all_ones.tflite