From 27d68573279ee078ec574f7262513b91f5fe11b7 Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Mon, 11 Aug 2025 23:45:34 +0100
Subject: [PATCH 01/12] Update atsw.xml
Added button templates for up and down buttons as well as button tool tips
---
AdvancedTradeSkillWindow/atsw.xml | 241 +++++++++++++++++++++++++++++-
1 file changed, 237 insertions(+), 4 deletions(-)
diff --git a/AdvancedTradeSkillWindow/atsw.xml b/AdvancedTradeSkillWindow/atsw.xml
index 4ed46f3..bce7973 100644
--- a/AdvancedTradeSkillWindow/atsw.xml
+++ b/AdvancedTradeSkillWindow/atsw.xml
@@ -1639,10 +1639,68 @@
- ATSW_DeleteJob(this.jobindex);
+ ATSW_MoveJobDown(this.jobindex);
+
+
+ GameTooltip:SetOwner(this, "ANCHOR_RIGHT");
+ GameTooltip:SetText("Remove craft from the queue");
+ GameTooltip:Show();
+
+
+ GameTooltip:Hide();
+
+
+
+
+
@@ -1666,11 +1724,70 @@
- ATSW_DeleteJob(this.jobindex);
+ ATSW_MoveJobDown(this.jobindex);
+
+
+ GameTooltip:SetOwner(this, "ANCHOR_RIGHT");
+ GameTooltip:SetText("Remove craft from the queue");
+ GameTooltip:Show();
+
+
+ GameTooltip:Hide();
+
+
+
+
+
+
@@ -1695,8 +1812,66 @@
ATSW_DeleteJob(this.jobindex);
+
+ GameTooltip:SetOwner(this, "ANCHOR_RIGHT");
+ GameTooltip:SetText("Remove craft from the queue");
+ GameTooltip:Show();
+
+
+ GameTooltip:Hide();
+
+
+
+
+
@@ -1720,10 +1895,68 @@
- ATSW_DeleteJob(this.jobindex);
+ ATSW_MoveJobDown(this.jobindex);
+
+ GameTooltip:SetOwner(this, "ANCHOR_RIGHT");
+ GameTooltip:SetText("Remove craft from the queue");
+ GameTooltip:Show();
+
+
+ GameTooltip:Hide();
+
+
+
@@ -4132,4 +4365,4 @@
-
\ No newline at end of file
+
From 1241b39c3f7366d24f6debfecbc57009ea4dd98f Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Mon, 11 Aug 2025 23:46:42 +0100
Subject: [PATCH 02/12] Update atsw.lua
Added ability to move queued crafts up and down the queue. Also combined search filter to look at recipes and reagents by default
---
AdvancedTradeSkillWindow/atsw.lua | 77 +++++++++++++++++++++++++++++--
1 file changed, 73 insertions(+), 4 deletions(-)
diff --git a/AdvancedTradeSkillWindow/atsw.lua b/AdvancedTradeSkillWindow/atsw.lua
index 45d512e..dfda382 100644
--- a/AdvancedTradeSkillWindow/atsw.lua
+++ b/AdvancedTradeSkillWindow/atsw.lua
@@ -356,7 +356,7 @@ function ATSWFrame_OnEvent()
ATSWFilterButton:SetHeight(20)
ATSWFilterButton:SetWidth(70)
end
- if (IsAddOnLoaded('Blizzard_TradeSkillUI') and getglobal('TradeSkillListScrollFrame')) then
+ if (IsAddOnLoaded('Blizzard_TradeSkillUI')) then
getglobal('TradeSkillListScrollFrame').offset = 0
end
elseif(event=="CRAFT_CLOSE") then
@@ -1282,16 +1282,32 @@ function ATSWFrame_UpdateQueue()
local queueName=getglobal("ATSWQueueItem"..i.."NameText");
local queueItem=getglobal("ATSWQueueItem"..i);
local queueButton=getglobal("ATSWQueueItem"..i.."DeleteButton");
+ local downButton=getglobal("ATSWQueueItem"..i.."DownButton");
+ local upButton=getglobal("ATSWQueueItem"..i.."UpButton")
if(atsw_queue[jobindex]) then
queueCount:SetText(atsw_queue[jobindex].count.."x");
queueName:SetText(atsw_queue[jobindex].name);
queueItem.jobindex=jobindex;
queueButton.jobindex=jobindex;
+ downButton.jobindex=jobindex;
+ upButton.jobindex=jobindex;
queueItem:Show();
queueButton:Show();
+ if(jobindex >= jobs) then
+ downButton:Hide();
else
+ downButton:Show();
+ end
+ if(jobindex <= 1) then
+ upButton:Hide();
+ else
+ upButton:Show();
+ end
+ else
queueButton:Hide();
queueItem:Hide();
+ downButton:Hide();
+ upButton:Hide();
end
end
@@ -1359,6 +1375,34 @@ function ATSW_DeleteJob(jobindex)
end
end
+function ATSW_MoveJobUp(jobindex)
+ if(jobindex > 1) then
+ local temp = atsw_queue[jobindex-1];
+ atsw_queue[jobindex-1] = atsw_queue[jobindex];
+ atsw_queue[jobindex] = temp;
+ if(atsw_preventupdate==false) then
+ ATSW_ResetPossibleItemCounts();
+ ATSWInv_UpdateQueuedItemList();
+ ATSWFrame_UpdateQueue();
+ ATSWFrame_Update();
+ end
+ end
+end
+
+function ATSW_MoveJobDown(jobindex)
+ if(jobindex < table.getn(atsw_queue)) then
+ local temp = atsw_queue[jobindex+1];
+ atsw_queue[jobindex+1] = atsw_queue[jobindex];
+ atsw_queue[jobindex] = temp;
+ if(atsw_preventupdate==false) then
+ ATSW_ResetPossibleItemCounts();
+ ATSWInv_UpdateQueuedItemList();
+ ATSWFrame_UpdateQueue();
+ ATSWFrame_Update();
+ end
+ end
+end
+
function ATSW_AddJobLL(skillname, num)
for i=1,table.getn(atsw_queue),1 do
if(atsw_queue[i].name==skillname) then
@@ -2162,9 +2206,34 @@ function ATSW_Filter(skillname)
end
for i=1,table.getn(parameters),1 do
if(parameters[i].name=="name") then
- if(string.find(string.lower(skillname),".-"..string.lower(parameters[i].value)..".-")==nil) then
+ -- Search both recipe name and reagents by default ||| START OF CODE
+ local nameMatch = string.find(string.lower(skillname),".-"..string.lower(parameters[i].value)..".-");
+ local reagentMatch = false;
+
+ -- Check reagents if name doesn't match
+ if(nameMatch == nil) then
+ local index=ATSW_GetTradeSkillListPosByName(skillname);
+ if(index~=-1) then
+ for j=1,table.getn(atsw_tradeskilllist[index].reagents),1 do
+ if(string.find(string.lower(atsw_tradeskilllist[index].reagents[j].name),".-"..string.lower(parameters[i].value)..".-")~=nil) then
+ reagentMatch=true;
+ break;
+ end
+ end
+ end
+ end
+
+ -- Return false only if neither name nor reagents match
+ if(nameMatch == nil and reagentMatch == false) then
return false;
end
+ -- Search both recipe name and reagents by default ||| END OF CODE
+
+ --[[ ||| ORIGINAL CODE THAT DOES NOT COMBINE FILTERS
+ if(string.find(string.lower(skillname),".-"..string.lower(parameters[i].value)..".-")==nil) then
+ return false;
+ end
+ ]]
end
if(parameters[i].name=="reagent" or parameters[i].name=="r") then
local index=ATSW_GetTradeSkillListPosByName(skillname);
@@ -2706,7 +2775,7 @@ function ATSWShoppingListFrameOnUpdate()
if aux_frame and aux_frame:IsVisible() then
ATSWShoppingListFrame:ClearAllPoints();
- ATSWShoppingListFrame:SetPoint("TOPRIGHT","aux_frame","BOTTOMRIGHT",0,0);
+ ATSWShoppingListFrame:SetPoint("TOPRIGHT","aux_frame","BOTTOMRIGHT", 28,-10);
else
ATSWShoppingListFrame:SetPoint("TOPLEFT","AuctionFrame","TOPLEFT",353,-436);
end
@@ -3053,4 +3122,4 @@ end
function ATSW_NOP()
-- do nothing!
-end
\ No newline at end of file
+end
From 52b8006efc6afedee6ae3431a630cf4ac0061178 Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Mon, 11 Aug 2025 23:48:41 +0100
Subject: [PATCH 03/12] Update README.txt
Added 0.5.7 update description
---
AdvancedTradeSkillWindow/README.txt | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/AdvancedTradeSkillWindow/README.txt b/AdvancedTradeSkillWindow/README.txt
index d0824e8..1c5a7e6 100644
--- a/AdvancedTradeSkillWindow/README.txt
+++ b/AdvancedTradeSkillWindow/README.txt
@@ -289,4 +289,8 @@ v0.5.6
- Added "enchant" links support (aux not understand it yet)
v0.5.6a
-- Fix errors after RightClick on reagents
\ No newline at end of file
+- Fix errors after RightClick on reagents
+
+v0.5.7
+- Added ability to move queued crafts up and down the queue list
+- Combined searching recipes and reagents into the default search.
From 6edd44b0c79d2dd1dd7da8606aba2b1b55a0ab87 Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Mon, 11 Aug 2025 23:49:22 +0100
Subject: [PATCH 04/12] Update AdvancedTradeSkillWindow.toc
version string update.
---
AdvancedTradeSkillWindow/AdvancedTradeSkillWindow.toc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/AdvancedTradeSkillWindow/AdvancedTradeSkillWindow.toc b/AdvancedTradeSkillWindow/AdvancedTradeSkillWindow.toc
index 77708cf..440423b 100644
--- a/AdvancedTradeSkillWindow/AdvancedTradeSkillWindow.toc
+++ b/AdvancedTradeSkillWindow/AdvancedTradeSkillWindow.toc
@@ -2,7 +2,7 @@
## Title: AdvancedTradeSkillWindow
## Notes: An improved window for your tradeskills for Vanilla
## RequiredDeps:
-## Version: v0.5.8
+## Version: v0.5.9
## SavedVariables: atsw_orderby, atsw_bankitemlist, atsw_merchantlist, atsw_itemlist, atsw_considerbank, atsw_consideralts, atsw_considermerchants, atsw_autobuy, atsw_multicount, atsw_recipetooltip, atsw_customsorting, atsw_customheaders, atsw_displayshoppinglist, atsw_disabled, atsw_savedqueue, atsw_savednecessaryitems
## X-ReleaseDate: $Date: 2024-11-18 $
@@ -11,4 +11,4 @@
## X-Website: https://github.com/laytya/AdvancedTradeSkillWindow-vanilla
atsw.xml
-atsw_customsorting.xml
\ No newline at end of file
+atsw_customsorting.xml
From ee1dc19219a5c6c913f3d9eed7f9092d1991945d Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Mon, 11 Aug 2025 23:50:16 +0100
Subject: [PATCH 05/12] Update README.txt
Corrected versioning to match TOC
---
AdvancedTradeSkillWindow/README.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/AdvancedTradeSkillWindow/README.txt b/AdvancedTradeSkillWindow/README.txt
index 1c5a7e6..fa04a80 100644
--- a/AdvancedTradeSkillWindow/README.txt
+++ b/AdvancedTradeSkillWindow/README.txt
@@ -292,5 +292,8 @@ v0.5.6a
- Fix errors after RightClick on reagents
v0.5.7
+- No update information provided by author.
+
+v0.5.8
- Added ability to move queued crafts up and down the queue list
- Combined searching recipes and reagents into the default search.
From 2c5b3a93e20595e3751c0cb12b3c9c1d0effb5e8 Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Mon, 11 Aug 2025 23:51:23 +0100
Subject: [PATCH 06/12] Update atsw.lua
Corrected line 1 comment to show correct version.
---
AdvancedTradeSkillWindow/atsw.lua | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/AdvancedTradeSkillWindow/atsw.lua b/AdvancedTradeSkillWindow/atsw.lua
index dfda382..63751b4 100644
--- a/AdvancedTradeSkillWindow/atsw.lua
+++ b/AdvancedTradeSkillWindow/atsw.lua
@@ -1,4 +1,4 @@
--- Advanced Trade Skill Window v0.5.6a for Vanilla
+-- Advanced Trade Skill Window v0.5.8 for Vanilla 1.12
-- copyright 2006 by Rene Schneider (Slarti on EU-Blackhand), 2017 by laytya
-- main script file
From 95bfb72ed527ef55bbeb9859cdf228b05b23c369 Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Tue, 12 Aug 2025 11:19:50 +0100
Subject: [PATCH 07/12] Update atsw.lua
Added :craft filter to replace the default search functionality now we're modified that default to search for craft AND reagents
---
AdvancedTradeSkillWindow/atsw.lua | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/AdvancedTradeSkillWindow/atsw.lua b/AdvancedTradeSkillWindow/atsw.lua
index 63751b4..d54269e 100644
--- a/AdvancedTradeSkillWindow/atsw.lua
+++ b/AdvancedTradeSkillWindow/atsw.lua
@@ -2235,6 +2235,14 @@ function ATSW_Filter(skillname)
end
]]
end
+ -- Added :craft filter to replace original search behavior where only craft recipe names were searched
+ if(parameters[i].name=="craft" or parameters[i].name=="c") then
+ -- Search only recipe names (original behavior)
+ if(string.find(string.lower(skillname),".-"..string.lower(parameters[i].value)..".-")==nil) then
+ return false;
+ end
+ end
+ --
if(parameters[i].name=="reagent" or parameters[i].name=="r") then
local index=ATSW_GetTradeSkillListPosByName(skillname);
if(index~=-1) then
@@ -2434,6 +2442,7 @@ function ATSW_BuildFilterDropDown()
[7] = { ":maxlevel 60", "Max Level", ":maxlevel [level]", "Filters the list to only include recipes for items with no more than the given level requirement." },
[8] = { ":maxrarity blue", "Max Rarity", ":maxrarity [grey|white|green|blue|purple]", "Filters the list to only include recipes for items with no more than the given rarity." },
[9] = { ":reagent ", "Reagents", ":reagent [reagent name]", "Filters the list to only include items that need the specified reagent." },
+ [10] = {":craft", "Crating Recipe", ":craft: [recipe name]", "Filters the list to only include recipes with the specific name"},
}
for filter, values in ipairs(filters) do
From f8f865c5a87df14db99c30971cc376a4b057e367 Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Tue, 12 Aug 2025 11:27:57 +0100
Subject: [PATCH 08/12] Update atsw.xml
Corrected function errors in delete button 1 and delete button 2
---
AdvancedTradeSkillWindow/atsw.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/AdvancedTradeSkillWindow/atsw.xml b/AdvancedTradeSkillWindow/atsw.xml
index bce7973..253f639 100644
--- a/AdvancedTradeSkillWindow/atsw.xml
+++ b/AdvancedTradeSkillWindow/atsw.xml
@@ -1639,7 +1639,7 @@
- ATSW_MoveJobDown(this.jobindex);
+ ATSW_DeleteJob(this.jobindex);
GameTooltip:SetOwner(this, "ANCHOR_RIGHT");
@@ -1724,7 +1724,7 @@
- ATSW_MoveJobDown(this.jobindex);
+ ATSW_DeleteJob(this.jobindex);
GameTooltip:SetOwner(this, "ANCHOR_RIGHT");
From 9a3d24b8df20cc379add554e5530f101447aa413 Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Tue, 12 Aug 2025 13:01:00 +0100
Subject: [PATCH 09/12] Update atsw.xml
Bug Fix: Delete button 4 was calling the wrong function
---
AdvancedTradeSkillWindow/atsw.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/AdvancedTradeSkillWindow/atsw.xml b/AdvancedTradeSkillWindow/atsw.xml
index 253f639..0eb0ab7 100644
--- a/AdvancedTradeSkillWindow/atsw.xml
+++ b/AdvancedTradeSkillWindow/atsw.xml
@@ -1895,7 +1895,7 @@
- ATSW_MoveJobDown(this.jobindex);
+ ATSW_DeleteJob(this.jobindex);
GameTooltip:SetOwner(this, "ANCHOR_RIGHT");
From 6bde5d618dd4ce2858d2d522dd3f49b71b5657bd Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Tue, 12 Aug 2025 13:01:53 +0100
Subject: [PATCH 10/12] Update atsw.lua
Up button for item 1 and down button for item 4 are now using the disabled texture instead of hidden to create a more visually consitent UI
---
AdvancedTradeSkillWindow/atsw.lua | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/AdvancedTradeSkillWindow/atsw.lua b/AdvancedTradeSkillWindow/atsw.lua
index d54269e..3660cd0 100644
--- a/AdvancedTradeSkillWindow/atsw.lua
+++ b/AdvancedTradeSkillWindow/atsw.lua
@@ -1293,15 +1293,17 @@ function ATSWFrame_UpdateQueue()
upButton.jobindex=jobindex;
queueItem:Show();
queueButton:Show();
+ downButton:Show();
+ upButton:Show();
if(jobindex >= jobs) then
- downButton:Hide();
+ downButton:Disable();
else
- downButton:Show();
+ downButton:Enable();
end
if(jobindex <= 1) then
- upButton:Hide();
+ upButton:Disable();
else
- upButton:Show();
+ upButton:Enable();
end
else
queueButton:Hide();
From 2dc75d07bb18796be6a2dc433a610532137bc66d Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Tue, 12 Aug 2025 13:11:41 +0100
Subject: [PATCH 11/12] Update atsw.lua
Added Alt+Click to queue 1x item craft. Updated tooltip to explain this.
---
AdvancedTradeSkillWindow/atsw.lua | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/AdvancedTradeSkillWindow/atsw.lua b/AdvancedTradeSkillWindow/atsw.lua
index 3660cd0..1bfc857 100644
--- a/AdvancedTradeSkillWindow/atsw.lua
+++ b/AdvancedTradeSkillWindow/atsw.lua
@@ -828,6 +828,22 @@ function ATSWSkillButton_OnClick(button)
if(button=="LeftButton") then
ATSWFrame_SetSelection(this:GetID(),true);
ATSWFrame_Update();
+
+ -- Alt+Click to add 1x to queue
+ if(IsAltKeyDown()) then
+ local skillName, skillType, numAvailable;
+ local listpos=ATSW_GetSkillListingPos(this:GetID());
+ if(atsw_skilllisting[listpos]) then
+ skillName = atsw_skilllisting[listpos].name;
+ skillType = atsw_skilllisting[listpos].type;
+ end
+
+ -- Only add to queue if it's not a header and has a valid skill name
+ if(skillName and skillType ~= "header") then
+ ATSW_AddJob(skillName, 1);
+ ATSWFrame_UpdateQueue();
+ end
+ end
end
end
@@ -2484,7 +2500,7 @@ function ATSW_DisplayTradeskillTooltip()
skillType = atsw_skilllisting[listpos].type;
else
skillName=nil;
- akillType=nil;
+ skillType=nil;
end
if(skillName and skillType ~= "header") then
@@ -2515,6 +2531,8 @@ function ATSW_DisplayTradeskillTooltip()
end
end
ATSWTradeskillTooltip:AddLine(ATSW_TOOLTIP_LEGEND);
+ ATSWTradeskillTooltip:AddLine(" ");
+ ATSWTradeskillTooltip:AddLine("Alt+Click to add craft to queue (x1)");
ATSWTradeskillTooltip:Show();
end
From 5aa0e5a3c6791bb8c3c2d08f7518874e129cb6c7 Mon Sep 17 00:00:00 2001
From: KameleonUK <42344512+KameleonUK@users.noreply.github.com>
Date: Tue, 12 Aug 2025 15:33:33 +0100
Subject: [PATCH 12/12] Update README.md
Added 0.5.8 info
---
README.md | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/README.md b/README.md
index 4203604..530560d 100644
--- a/README.md
+++ b/README.md
@@ -43,6 +43,12 @@ of "green".
## Changelog:
+v0.5.8
+- Added ability to move queued crafts up and down the list
+- Alt left click will add x1 craft of that item to the queue
+- Changed default search behavior to search recipe names and reagents
+- added :craft predefined filter to replace original search functionality (searches crafted item names only)
+
v0.5.7
- Fix for scroll jumps
- Added presets for easy filter select